Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable cram tests on Windows #324

Closed

Conversation

guillermooo
Copy link
Contributor

Disable tests that always fail on Windows.

I've included a very basic implementation of skipIf for older versions of Python so that the tests at least can run. Let me know if you think it's good enough.

Includes an ad-hoc implementation of skipIf for older platforms
that don't support it by default.
@@ -31,6 +45,8 @@


class CramPluginTests(unittest.TestCase):

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a mock test that doesn't execute anything. No reason to disable those tests.

@arcivanov
Copy link
Member

I'm confused. The cram tests do not actually invoke cram - all of the calls are mocked out. Why are we trying to exclude them, again?

@guillermooo
Copy link
Contributor Author

@arcivanov IIRC they were causing errors on Windows for some reason. I'm not very familiar with the pybuilder codebase, though, so I'll doublecheck the output.

@esc
Copy link
Contributor

esc commented Feb 18, 2016

Getting things to run on appveyor might shed some more light on this?

@AlexeySanko
Copy link
Contributor

AlexeySanko commented Dec 28, 2016

Hi, guys.

When I were .... young I tried to create developing PyBuilder process available for Windows. After a huge of ...... experience I installed VirtualBox with Ubuntu. :)))

  1. So cram unittests fail because Windows has other paths format. So you can find addopted unittest file there
    Of course this file could be used only for comparison (!!!)

  2. Cram could work on Windows. But You need modify local cram:
    a) take windows addopted cram sources
    So I created corresponding pull request for cram, but now I'm not sure that it's good idea :)
    b) compile cram.exe file and place it to bin (Scripts) folder. I used tool called PyInstaller
    Do not forget do change cram test - Windows cmd.exe utility has specific header. :)))

As you can see into my branch for Windows we need to do a lot of changes into unitests. And into integration tests (I didn't do it). And create separated tests for Unix and Windows (for coverage). And support all this stuff after that. In result I'm not sure that it's good idea.

@arcivanov
Copy link
Member

Fixed in and obsoleted by #648

@arcivanov arcivanov closed this Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants