-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable cram tests on Windows #324
Conversation
Includes an ad-hoc implementation of skipIf for older platforms that don't support it by default.
49ec637
to
d67368c
Compare
@@ -31,6 +45,8 @@ | |||
|
|||
|
|||
class CramPluginTests(unittest.TestCase): | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a mock test that doesn't execute anything. No reason to disable those tests.
I'm confused. The cram tests do not actually invoke cram - all of the calls are mocked out. Why are we trying to exclude them, again? |
@arcivanov IIRC they were causing errors on Windows for some reason. I'm not very familiar with the pybuilder codebase, though, so I'll doublecheck the output. |
Getting things to run on appveyor might shed some more light on this? |
Hi, guys. When I were .... young I tried to create developing PyBuilder process available for Windows. After a huge of ...... experience I installed VirtualBox with Ubuntu. :)))
As you can see into my branch for Windows we need to do a lot of changes into unitests. And into integration tests (I didn't do it). And create separated tests for Unix and Windows (for coverage). And support all this stuff after that. In result I'm not sure that it's good idea. |
Fixed in and obsoleted by #648 |
Disable tests that always fail on Windows.
I've included a very basic implementation of skipIf for older versions of Python so that the tests at least can run. Let me know if you think it's good enough.