New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyBuilder install_dependencies behavior should mirror #340 #347

Merged
merged 1 commit into from Apr 15, 2016

Conversation

Projects
None yet
3 participants
@arcivanov
Contributor

arcivanov commented Apr 8, 2016

  1. Got rid of Mockito entirely. This resulted in finding a huge bug in reactor tests whereas the plugin loader in the actual (not mocked) reactor was substituted with a mock plugin loader affecting further reactor behavior. https://github.com/pybuilder/pybuilder/pull/347/files#diff-9584cce2b40001f24aa966f2329c0bc7R50 https://github.com/pybuilder/pybuilder/pull/347/files#diff-9584cce2b40001f24aa966f2329c0bc7R421
  2. We use Unittest.Mock where it is available and Mock elsewhere. Dependencies are adjusted accordingly.
  3. All of the PIP internal stuff is moved into pip_common (to expose Version and SpecifierSet) while pip_utils contains PIP-related utilities. https://github.com/pybuilder/pybuilder/pull/347/files#diff-3f7930768a016caa358fe51c630f08cfR1
  4. Corollary to self-updating (since we use PIP internals) is reloading of PIP post-update to allow incompatible migrations from 6 to 8 etc. https://github.com/pybuilder/pybuilder/pull/347/files#diff-001479a18f1db7b9cde893d99c6734f1R133
  5. Logic related to what to install is concentrated here: https://github.com/pybuilder/pybuilder/pull/347/files#diff-001479a18f1db7b9cde893d99c6734f1R136
  6. Logic related to how to install (if there are individual install targets or URL install causing force-reinstall must install separately, otherwise can batch) is here:
    https://github.com/pybuilder/pybuilder/pull/347/files#diff-001479a18f1db7b9cde893d99c6734f1R106

fixes #346, connected to #346

@mriehl

This comment has been minimized.

Show comment
Hide comment
@mriehl

mriehl Apr 11, 2016

Member

@arcivanov is this ready for review or are you still tinkering with it?

Member

mriehl commented Apr 11, 2016

@arcivanov is this ready for review or are you still tinkering with it?

@arcivanov

This comment has been minimized.

Show comment
Hide comment
@arcivanov

arcivanov Apr 11, 2016

Contributor

@mriehl still tinkering, hence the WIP label

Contributor

arcivanov commented Apr 11, 2016

@mriehl still tinkering, hence the WIP label

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Apr 12, 2016

Coverage Status

Coverage increased (+1.6%) to 72.063% when pulling d9c29ac on arcivanov:issue_346 into bc3b670 on pybuilder:master.

coveralls commented Apr 12, 2016

Coverage Status

Coverage increased (+1.6%) to 72.063% when pulling d9c29ac on arcivanov:issue_346 into bc3b670 on pybuilder:master.

@arcivanov

This comment has been minimized.

Show comment
Hide comment
@arcivanov

arcivanov Apr 12, 2016

Contributor

@mriehl ready for preliminary review

Contributor

arcivanov commented Apr 12, 2016

@mriehl ready for preliminary review

@arcivanov

This comment has been minimized.

Show comment
Hide comment
@arcivanov

arcivanov Apr 13, 2016

Contributor

@mriehl @esc bump

Contributor

arcivanov commented Apr 13, 2016

@mriehl @esc bump

" from %s" % url if url else "")
log_file = project.expand_path("$dir_install_logs", dependency.name)
log_file = re.sub(r'<|>|=', '_', log_file)
def install_dependency(logger, project, dependencies):

This comment has been minimized.

@mriehl

mriehl Apr 14, 2016

Member

I think this should be install_dependencies now

@mriehl

mriehl Apr 14, 2016

Member

I think this should be install_dependencies now

This comment has been minimized.

@arcivanov

arcivanov Apr 14, 2016

Contributor

backward compatibility. I'll alias it.

@arcivanov

arcivanov Apr 14, 2016

Contributor

backward compatibility. I'll alias it.

This comment has been minimized.

@arcivanov

arcivanov Apr 15, 2016

Contributor

can't alias it, conflicts with task function. at any rate it supports 1 to many

@arcivanov

arcivanov Apr 15, 2016

Contributor

can't alias it, conflicts with task function. at any rate it supports 1 to many

Show outdated Hide outdated src/main/python/pybuilder/plugins/python/install_dependencies_plugin.py
_do_install_dependency(logger, project, standalone_dependency,
True,
url,
local_mapping[dependency.name] if dependency.name in local_mapping else None,

This comment has been minimized.

@mriehl

mriehl Apr 14, 2016

Member

dict().get('key')?

@mriehl

mriehl Apr 14, 2016

Member

dict().get('key')?

This comment has been minimized.

@arcivanov

arcivanov Apr 14, 2016

Contributor

makes sense, thanks.

@arcivanov

arcivanov Apr 14, 2016

Contributor

makes sense, thanks.

@mriehl

This comment has been minimized.

Show comment
Hide comment
@mriehl

mriehl Apr 14, 2016

Member

Good stuff, and nice find on the mock.

Member

mriehl commented Apr 14, 2016

Good stuff, and nice find on the mock.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Apr 15, 2016

Coverage Status

Coverage decreased (-0.06%) to 72.207% when pulling eb036f4 on arcivanov:issue_346 into 157420e on pybuilder:master.

coveralls commented Apr 15, 2016

Coverage Status

Coverage decreased (-0.06%) to 72.207% when pulling eb036f4 on arcivanov:issue_346 into 157420e on pybuilder:master.

@arcivanov arcivanov merged commit c6f9689 into pybuilder:master Apr 15, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.06%) to 72.207%
Details

@arcivanov arcivanov deleted the arcivanov:issue_346 branch Apr 15, 2016

@arcivanov arcivanov removed the in progress label Apr 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment