Switch to Jenkinsfile for jenkins job configuration #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
reviewed
Apr 15, 2017
Jenkinsfile
Outdated
| def build(label, toxenv) { | ||
| try { | ||
| checkout scm | ||
| if (label.startsWith("windows")) { |
There was a problem hiding this comment.
All of our builders appear to be windows for now?
There was a problem hiding this comment.
(FreeBSD comes next to match the existing bcrypt PR builder)
Jenkinsfile
Outdated
|
|
||
| def build(label, toxenv) { | ||
| try { | ||
| checkout scm |
reaperhulk
force-pushed
the
jenkinsfile
branch
2 times, most recently
from
cafe67f
to
8bd48fc
Compare
|
This is now ready for review. One caveat: the ansiColor build wrapper is currently of limited utility and doesn't work except in the combined console output view. |
|
Also, the separation of scm checkout into a different stage makes the non-blue ocean view pretty unreadable. |
alex
reviewed
Apr 28, 2017
Jenkinsfile
Outdated
| } | ||
|
|
||
| def builders = [:] | ||
| for (x in configs) { |
alex
reviewed
Apr 28, 2017
Jenkinsfile
Outdated
| def label = x["label"] | ||
| def toxenvs = x["toxenvs"] | ||
|
|
||
| for (y in toxenvs) { |
alex
reviewed
Apr 28, 2017
Jenkinsfile
Outdated
| } else { | ||
| ansiColor('xterm') { | ||
| sh """ | ||
| tox -r -e $toxenv -- --color=yes |
|
Besides those comments, is there anything blocking landing thsi? |
alex
approved these changes
Apr 28, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is WIP until FreeBSD 11 is added (and it actually works)