-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix alpine #79
Fix alpine #79
Conversation
# define __USE_BSD | ||
# define _DEFAULT_SOURCE | ||
# if !defined(_BSD_SOURCE) | ||
# define _BSD_SOURCE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You know what's BSD? Literally everything.
LGTM modulo comments |
I have found the musl entry about this: Should we just use the libsodium-style:
and
If this is in the bcrypt code from OpenBSD, I'm surprised to find things that use glibc internals there. |
(I know you mentioned never using a C++ compiler, but hopefully we can preempt unnecessary problems for people who end up doing that by accident.) |
I'm okay with switching this. Hopefully that works in VS2008 as well :) |
Not sure if Travis is being hilariously slow or is just broken. |
I have cancelled and restarted the build. |
Travis's mac builders are completely dead and have been all day. Canceling won't help. We get to wait :( |
None of the other builders did anything though; they were all stuck in yellow. |
Fixes compilation on alpine linux and cleans up a bunch of warnings that can occur on platforms that don't use glibc.