Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alpine #79

Merged
merged 3 commits into from
Jun 30, 2016
Merged

Fix alpine #79

merged 3 commits into from
Jun 30, 2016

Conversation

reaperhulk
Copy link
Member

Fixes compilation on alpine linux and cleans up a bunch of warnings that can occur on platforms that don't use glibc.

# define __USE_BSD
# define _DEFAULT_SOURCE
# if !defined(_BSD_SOURCE)
# define _BSD_SOURCE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know what's BSD? Literally everything.

@lvh
Copy link
Member

lvh commented Jun 29, 2016

LGTM modulo comments

@lvh
Copy link
Member

lvh commented Jun 29, 2016

I have found the musl entry about this:

http://wiki.musl-libc.org/wiki/FAQ#Q:_I.27m_trying_to_compile_something_against_musl_and_I_get_error_messages_about_sys.2Fcdefs.h

Should we just use the libsodium-style:

#ifdef __cplusplus
extern "C" {
#endif

and

#ifdef __cplusplus
}
#endif

If this is in the bcrypt code from OpenBSD, I'm surprised to find things that use glibc internals there.

@lvh
Copy link
Member

lvh commented Jun 29, 2016

(I know you mentioned never using a C++ compiler, but hopefully we can preempt unnecessary problems for people who end up doing that by accident.)

@reaperhulk
Copy link
Member Author

I'm okay with switching this. Hopefully that works in VS2008 as well :)

@lvh
Copy link
Member

lvh commented Jun 29, 2016

Not sure if Travis is being hilariously slow or is just broken.

@lvh
Copy link
Member

lvh commented Jun 29, 2016

I have cancelled and restarted the build.

@reaperhulk
Copy link
Member Author

Travis's mac builders are completely dead and have been all day. Canceling won't help. We get to wait :(

@lvh
Copy link
Member

lvh commented Jun 29, 2016

None of the other builders did anything though; they were all stuck in yellow.

@lvh lvh merged commit c9c7621 into pyca:master Jun 30, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants