Inputing a 2y salt should output a 2y hash #84
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently using bcrypt 3.0 with passlib is a bit broken, because it it inputs a precomputed
$2y$
salt and expects to get back out a$2y$
hash (and it verifies that it does that), however instead it's getting back a$2b$
hash. Giving a$2b$
output when you give it a$2y$
input also means it breaks the most logical way to verify a bcrypt'd password since:would fail because instead of a
$2y$
we'd return a$2b$
.So this change will ensure that
hashpw()
returns the same prefix it was given originally. We still don't support the$2y$
prefix when passed intogensalt()
, so getting a$2y$
out ofhashpw()
will still require either pre-existing data or manually constructing your own salt.This also means our
checkpw
gets to be a little simpler since it no longer needs to deal with the fact that the output may differ only by the prefix.