Add PyPy ssl.py to Cryptography unittests.

[amauryfa]

Commit ce6fe07 removed "unused BIO bindings", but PyPy's own implementation of the ssl module uses the BIO_set_nbio function, and probably others in the same area.

Currently I cannot update PyPy with the latest version of Cryptography.

There is a Travis environment named "pypy3.5-5.10.1", could we add a test that the current version of Cryptography can be used to rebuild the _ssl module? This executes quickly, and certainly does not need a full PyPy translation. In my local client I do:

$ cd lib_pypy; ../pypy3-c _build_ssl.py; cd ..
$ ./pypy3-c -m test test_ssl

[alex]

Adding tests for this would be outstanding!

Can you send a PR for this? All you should need to do is add a new environment to .travis.yml (it should be one of the DOWNSTREAM builds), and then script it in .travis/run.sh.

[mattip]

@amauryfa how does _build_ssl.py pull in the latest version of cryptography?

[mattip]

It doesn't seem like .travis/run.sh is the proper thing to do, it does

# sets up a virtualenv 
$downstream_script install
pip install .
$downstream_script run

where we need to

#set up a clean pypy, i.e. in pypy2
cp -r src/_cffi_src pypy2/lib_pypy/_cffi_ssl
(cd pypy2/lib_pypy; ../bin/pypy _build_ssl.py)
pypy2/bin/pypy2 pypy2/lib-python/2.7/test/test_ssl.py

[alex]

Does the host Python need to be a PyPy?

…

On Sun, May 26, 2019 at 4:54 PM Matti Picus ***@***.***> wrote: It doesn't seem like .travis/run.sh is the proper thing to do, it does # sets up a virtualenv $downstream_script install pip install . $downstream_script run where we need to #set up a clean pypy, i.e. in pypy2 cp -r src/_cffi_src pypy2/lib_pypy/_cffi_ssl (cd pypy2/lib_pypy; ../bin/pypy _build_ssl.py) pypy2/bin/pypy2 pypy2/lib-python/2.7/test/test_ssl.py — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#4367?email_source=notifications&email_token=AAAAGBBKRD3CRLFMBPIEJI3PXL2HNA5CNFSM4FLNXG22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWINH2Q#issuecomment-496030698>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAAGBBZLWZXDNGX6SYU6EDPXL2HNANCNFSM4FLNXG2Q> .

-- All that is necessary for evil to succeed is for good people to do nothing.

[mattip]

Maybe not, you need some files from lib_pypy: _build_ssl.py, _ssl/__init__.py and the _cffi_ssl/_stdssl directory, maybe some others

[reaperhulk]

We're two years in and no action so I'm going to go ahead and close this.