Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recent aws-dynamodb-encryption-python change broke CI #4979

Closed
alex opened this issue Aug 31, 2019 · 4 comments
Closed

Recent aws-dynamodb-encryption-python change broke CI #4979

alex opened this issue Aug 31, 2019 · 4 comments
Labels
testing

Comments

@alex
Copy link
Member

alex commented Aug 31, 2019

CC: @mattsb42-aws

https://travis-ci.org/pyca/cryptography/jobs/579259777
@alex alex added the testing label Aug 31, 2019
@mattsb42-aws
Copy link
Contributor

.... :/ that shouldn't be happening...
I'll take a look and find out why our isolation tests didn't catch this.

@mattsb42-aws mattsb42-aws mentioned this issue Sep 3, 2019
Closed
@alex
Copy link
Member Author

alex commented Sep 3, 2019

Thanks for taking a look!

@mattsb42-aws mattsb42-aws mentioned this issue Sep 3, 2019
Merged
1 task
@mattsb42-aws
Copy link
Contributor

This should be fixed now, and this particular class of error should be caught in our CI now, before any changes get into the branch you are pulling from.

@alex
Copy link
Member Author

alex commented Sep 3, 2019

Confirmed.

@alex alex closed this as completed Sep 3, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
testing
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alex @mattsb42-aws