Skip to content

Fix upstream tests #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 3, 2019
Merged

Fix upstream tests #123

merged 2 commits into from
Sep 3, 2019

Conversation

mattsb42-aws
Copy link
Member

@mattsb42-aws mattsb42-aws commented Sep 3, 2019 •
edited
Loading

Issue #, if available: #122 pyca/cryptography#4979

Description of changes:

  • Fixes upstream test environments to correctly block all environment variables.
  • Fixes integration test parameterization logic to fail at execution time rather than test collection time.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@mattsb42-aws mattsb42-aws merged commit 45f3826 into aws:master Sep 3, 2019
@mattsb42-aws mattsb42-aws deleted the fixit branch September 3, 2019 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@ttjsu-aws ttjsu-aws ttjsu-aws approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsb42-aws @ttjsu-aws