verification/policy: tweak key checks #10311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs C2SP/x509-limbo#185. Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
woodruffw
commented
Jan 31, 2024
| @@ -64,7 +67,7 @@ | |||
| "webpki::aki::root-with-aki-ski-mismatch", | |||
| # We allow RSA keys that aren't divisible by 8, which is technically | |||
| # forbidden under CABF. No other implementation checks this either. | |||
| "webpki::forbidden-rsa-key-not-divisable-by-8", | |||
There was a problem hiding this comment.
NB: This test was just renamed; no behavioral change.
alex
approved these changes
Feb 1, 2024
alex
pushed a commit
to alex/cryptography
that referenced
this pull request
Feb 24, 2024
* verification/policy: tweak key checks Needs C2SP/x509-limbo#185. Signed-off-by: William Woodruff <william@trailofbits.com> * bump limbo Signed-off-by: William Woodruff <william@trailofbits.com> --------- Signed-off-by: William Woodruff <william@trailofbits.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
valid_issuerlogic slightly, to the following:root -> EEconfiguration)With these changes, I've confirmed that the existing tests pass as expected (and additionally, the new tests in the limbo PR below also newly pass).
Needs C2SP/x509-limbo#185.