Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added bindings for SSL_renegotiate_<pending/abbreviated> #2303

Merged
merged 3 commits into from
Aug 28, 2015

Conversation

kjav
Copy link
Contributor

@kjav kjav commented Aug 28, 2015

This is to facilitate their use in the pyopenssl library.

@kjav
Copy link
Contributor Author

kjav commented Aug 28, 2015

Related to issue #2300

@alex
Copy link
Member

alex commented Aug 28, 2015

Jenkins, ok to test.

@reaperhulk
Copy link
Member

jenkins, ok to test

@alex alex added the bindings label Aug 28, 2015
@kjav
Copy link
Contributor Author

kjav commented Aug 28, 2015

@alex, I have a fork of the pyopenssl library which uses these bindings to add renegotiation functionality. When should I create the merge request? I'm worried the tests will fail as the cryptography version it uses might not be up to date with the changes in this merge.

@reaperhulk
Copy link
Member

Once this merges you can open a PR against pyopenssl. There are tests there that run against cryptography master. The tests against the latest release version will fail, but that's expected for now.

@alex
Copy link
Member

alex commented Aug 28, 2015

I don't think SSL_renegotiate_abbreviated exists in all versions of OpenSSL?

@kjav
Copy link
Contributor Author

kjav commented Aug 28, 2015

Do you have an example?

@reaperhulk
Copy link
Member

Looks like it was added sometime in 1.0.1 so that'll have to be conditionally bound. @kjav look at the jenkins status check on this PR right now if you want to see where it's failing.

As this is not supported in OpenSSL < 1.01
@kjav
Copy link
Contributor Author

kjav commented Aug 28, 2015

I added this binding on a whim - it is not required for the pyopenssl renegotiation support (the reason for this merge). I have removed it.

@codecov-io
Copy link

Current coverage is 99.98%

Merging #2303 into master will not affect coverage as of 157b529

@@            master   #2303   diff @@
======================================
  Files          115     115       
  Stmts        11950   11950       
  Branches      1334    1334       
  Methods          0       0       
======================================
  Hit          11948   11948       
  Partial          2       2       
  Missed           0       0       

Review entire Coverage Diff as of 157b529

Powered by Codecov. Updated on successful CI builds.

@kjav
Copy link
Contributor Author

kjav commented Aug 28, 2015

The checks have passed - can this be merged with master?

reaperhulk added a commit that referenced this pull request Aug 28, 2015
Added bindings for SSL_renegotiate_pending
@reaperhulk reaperhulk merged commit def82db into pyca:master Aug 28, 2015
reaperhulk added a commit to reaperhulk/cryptography that referenced this pull request Aug 30, 2015
Added bindings for SSL_renegotiate_pending
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

None yet

4 participants