-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added bindings for SSL_renegotiate_<pending/abbreviated> #2303
Conversation
Adds SSL_renegotiate binding
Related to issue #2300 |
Jenkins, ok to test. |
jenkins, ok to test |
@alex, I have a fork of the pyopenssl library which uses these bindings to add renegotiation functionality. When should I create the merge request? I'm worried the tests will fail as the cryptography version it uses might not be up to date with the changes in this merge. |
Once this merges you can open a PR against pyopenssl. There are tests there that run against cryptography master. The tests against the latest release version will fail, but that's expected for now. |
I don't think |
Do you have an example? |
Looks like it was added sometime in 1.0.1 so that'll have to be conditionally bound. @kjav look at the jenkins status check on this PR right now if you want to see where it's failing. |
As this is not supported in OpenSSL < 1.01
I added this binding on a whim - it is not required for the pyopenssl renegotiation support (the reason for this merge). I have removed it. |
Current coverage is
|
The checks have passed - can this be merged with master? |
Added bindings for SSL_renegotiate_pending
Added bindings for SSL_renegotiate_pending
This is to facilitate their use in the pyopenssl library.