Add convenience methods to sign and verify w/ RSA #2945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs tests and docs |
|
jenkins, ok to test |
cmurphy
changed the title
|
jenkins, retest this please |
| @@ -486,7 +514,8 @@ Key interfaces | |||
|
|
|||
| .. versionadded:: 0.3 | |||
|
|
|||
| Sign data which can be verified later by others using the public key. | |||
| Get object with which to sign potentially multiple blocks of data | |||
There was a problem hiding this comment.
The wording here is confusing. Could you rephrase it a bit?
This patch adds wrapper methods to allow the user to sign and verify a single message block without having to go through the multi-step process of creating a signer or verifier, updating it with the one message, and finalizing the result. This will make signing and verifying data more user-friendly when only using small messages. Partial bug pyca#1529
|
@reaperhulk thanks for those notes, I've reworded it to hopefully be simpler. |
|
Thanks for the PR @cmurphy! Feel free to add yourself to the AUTHORS file in a new PR if you'd like. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds wrapper methods to allow the user to sign and verify a
single message block without having to go through the multi-step
process of creating a signer or verifier, updating it with the one
message, and finalizing the result. This will make signing and
verifying data more user-friendly when only using small messages.
Partial bug #1529