add platform check to set library names for linking on windows #322
Conversation
|
We should get the Windows ci stuff sorted before this can be merged. |
|
Test PASSed. |
|
Test FAILed. |
Temporarily using pragma: no cover on it until we have windows coverage on travis. Windows builds will be done via jenkins for now.
|
Test FAILed. |
| if sys.platform != "win32": | ||
| libraries = ["crypto", "ssl"] | ||
| else: # pragma: no cover | ||
| libraries = ["libeay32", "ssleay32", "advapi32"] |
There was a problem hiding this comment.
I'm afraid to ask, but why do we need "advapi32"?
There was a problem hiding this comment.
Oh I can actually remove that until we land the os random engine. advapi32 is for cryptgenrandom.
There was a problem hiding this comment.
Sounds good. (I hate everything)
On Thu, Jan 23, 2014 at 8:19 PM, Paul Kehrer notifications@github.comwrote:
In cryptography/hazmat/bindings/openssl/binding.py:
@@ -79,9 +81,15 @@ def _ensure_ffi_initialized(cls):
if cls.ffi is not None and cls.lib is not None:
return
# platform check to set the right library namesif sys.platform != "win32":libraries = ["crypto", "ssl"]else: # pragma: no coverlibraries = ["libeay32", "ssleay32", "advapi32"]Oh I can actually remove that until we land the os random engine. advapi32
is for cryptgenrandom.—
Reply to this email directly or view it on GitHubhttps://github.com//pull/322/files#r9138609
.
"I disapprove of what you say, but I will defend to the death your right to
say it." -- Evelyn Beatrice Hall (summarizing Voltaire)
"The people's good is the highest law." -- Cicero
GPG Key fingerprint: 125F 5C67 DFE9 4084
|
Can you add windows support to the changelog? |
|
Test PASSed. |
|
Test PASSed. |
add platform check to set library names for linking on windows
Fixed pyca#322 -- removed code that already exists in cryptography
This is the last patch required to make windows work. This will drop our coverage <100% until we enable a windows build slave (and figure out how to get it integrated with coveralls)