[WIP] CommonCrypto Initial #344

reaperhulk · 2013-12-24T23:09:01Z

This PR is the base structure + hash support for CommonCrypto, an OS X cryptographic API.

Basic backend structure
Hash support
Basic docs
Determine how to skip basic cipher/hmac/hash tests if the backend doesn't support those operations. Ideally this won't require us to add a generator + separate function for each test?
Rebase to handle split backend/bindings
Determine how best to skip commoncrypto on unsupported platforms

alex · 2013-12-24T23:12:10Z

cryptography/hazmat/backends/commoncrypto/backend.py

+                "object": "CC_MD5_CTX *",
+                "init": self.lib.CC_MD5_Init,
+                "update": self.lib.CC_MD5_Update,
+                "final": self.lib.CC_MD5_Final},


These shouldn't be dicts, make them named tuples or something like that.

coveralls · 2013-12-24T23:28:19Z

Coverage remained the same when pulling 2c5596c on reaperhulk:common-crypto-base into 2a710fd on pyca:master.

alex · 2013-12-24T23:28:32Z

cryptography/hazmat/backends/commoncrypto/backend.py

+                )
+            ctx = self._backend.ffi.new(mapping["object"])
+            # init/update/final ALWAYS return 1
+            mapping["init"](ctx)


No error checking? If they're supposed to always return 1 we should have an assert res == 1

jenkins-cryptography · 2013-12-24T23:30:26Z

Test PASSed.
Refer to this link for build results: http://jenkins.cryptography.io/job/cryptography-pr-experimental/48/

jenkins-cryptography · 2013-12-25T07:19:46Z

Test PASSed.
Refer to this link for build results: http://jenkins.cryptography.io/job/cryptography-pr-experimental/58/

jenkins-cryptography · 2013-12-25T15:20:14Z

Test FAILed.
Refer to this link for build results: http://jenkins.cryptography.io/job/cryptography-pr-experimental/59/

coveralls · 2013-12-25T15:35:40Z

Coverage remained the same when pulling 3190ebe on reaperhulk:common-crypto-base into 0865a8b on pyca:master.

coveralls · 2013-12-25T18:47:27Z

Coverage decreased (-2.88%) when pulling 5922ac3 on reaperhulk:common-crypto-base into 0865a8b on pyca:master.

jenkins-cryptography · 2013-12-25T18:49:47Z

Test FAILed.
Refer to this link for build results: http://jenkins.cryptography.io/job/cryptography-pr-experimental/62/

* master: (28 commits) move macro from functions into macros where it belongs convert all functions without args from () to (void) update style guide docs to reflect change to (void) re-add some removed generators to simplify patch Add myself to AUTHORS change typeerror to valueerror expand the explanation for this workaround and switch XXX to TODO A handful of style fixes in the cffi bindings Use uintptr_t to get sufficiently wide storage for these types even on 32 bit Windows. Shorten long lines remove parameter names, fix some spacing Remove verify from Hash. Documentation clarity and grammer fixes. Update documentation on interface as well. refactor all tests to use mark instead of generator skips rename the method to be less horribly named add mark that allows us to do skip tests on backends via decorators remove SSL_OP_MSIE_SSLV2_RSA_PADDING fix a style error fix last warning (macro returns ASN1_ITEM_EXP *) ... Conflicts: pytest.ini tests/conftest.py

jenkins-cryptography · 2013-12-28T02:05:14Z

Test FAILed.
Refer to this link for build results: http://jenkins.cryptography.io/job/cryptography-pr-experimental/91/

coveralls · 2013-12-28T02:36:04Z

Coverage decreased (-2.8%) when pulling 17eac24 on reaperhulk:common-crypto-base into f82a03a on pyca:master.

* master: (41 commits) Correct spelling, fix phrasing, line wrap. Revert "Travis now has an up to date pypy" Make capitalization in the glossary consistent and sort it Make lib and ffi be private on backend Split OpenSSL binding Fixed test for earlier exceptino Rearrange Move GCM tag size/value validation farther forward -- this makes it easier by not requiring future backends to implement the same checks expose num_locks and {get,set}_{id,locking}_callback Make the PyPy tox job consistent with the main one. THis should be a seperate PR Typo fix This page has been subsumed by the index Bump the copyright year Document compiling OpenSSL to avoid conflicts missed some param names (C style fix) add the rest of the engine methods fix bogus merge Switch to long for these stand-in constants as suggested by reaperhulk to avoid compiler warnings Restore exposing a symbol when it's available. Refs pyca#351 ...

alex · 2014-01-03T05:30:50Z

cryptography/hazmat/backends/commoncrypto/backend.py

+
+        hashtuple = namedtuple('hash', 'object init update final')
+        self.hash_mappings = namedtuple('HashMapping',
+                                        'md5 sha1 sha224 sha256 sha384 sha512')


This shouldn't be a namedtuple, it should be a dict mapping hash algorithm classes to the tuples.

alex · 2014-01-03T05:31:23Z

cryptography/hazmat/backends/commoncrypto/backend.py

+        self._ffi = self._binding.ffi
+        self._lib = self._binding.lib
+
+        hashtuple = namedtuple('hash', 'object init update final')


This should be created at module level, also the naming could use a bit of level. Also use the "list" form of the constructor, not the str (i.e. namedtuple("Class", ["foo", "bar"]))

coveralls · 2014-01-03T05:39:21Z

Coverage remained the same when pulling a17d834 on reaperhulk:common-crypto-base into adbea0d on pyca:master.

jenkins-cryptography · 2014-01-03T05:45:18Z

Test PASSed.
Refer to this link for build results: http://jenkins.cryptography.io/job/cryptography-pr-experimental/171/

public · 2014-01-03T12:08:32Z

cryptography/hazmat/bindings/commoncrypto/common_digest.py

+"""
+
+FUNCTIONS = """
+extern int CC_MD5_Init(CC_MD5_CTX *);


Why are these all extern?

* master: backend support check now lists which backend caused the skip add to author list Also use an absolute path for the about file Include a long description in our setup.py Explanatory comment So the tests don't all explode fixed typo flake8 test for ctr Tests for OFB and CFB Implement this for CTR Validate the IV/nonce length for a given algorithm.

* master: improve docstring fix indentation mistake import build_ffi directly remove verify_kwargs and replace with pre_include/post_include/libraries refactor bindings to reduce code duplication with multiple backends instantiate hash objects for hmac checks too Instantiate our hash objects used for supported checks

alex · 2014-01-04T19:28:20Z

You may hate me for this, what do you think about splitting up the bindings and the backend bits into seperate PRs?

reaperhulk · 2014-01-04T19:30:25Z

So put the cryptography.hazmat.bindings.commoncrypto stuff into a PR and then build the backend PR on that? That's a pretty simple one to split out so I can do that. I'll hate you later ;)

alex · 2014-01-04T19:31:34Z

Sounds good. Mostly I want to avoid re-reviewing bits of the backend stuff,
when we need to get the bindings stuff done first.

On Sat, Jan 4, 2014 at 11:30 AM, Paul Kehrer notifications@github.comwrote:

So put the cryptography.hazmat.bindings.commoncrypto stuff into a PR and
then build the backend PR on that? That's a pretty simple one to split out
so I can do that. I'll hate you later ;)

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/344#issuecomment-31586449
.

"I disapprove of what you say, but I will defend to the death your right to
say it." -- Evelyn Beatrice Hall (summarizing Voltaire)
"The people's good is the highest law." -- Cicero
GPG Key fingerprint: 125F 5C67 DFE9 4084

coveralls · 2014-01-04T19:33:12Z

Coverage remained the same when pulling c8afb31 on reaperhulk:common-crypto-base into d68fd37 on pyca:master.

jenkins-cryptography · 2014-01-04T19:48:15Z

Test PASSed.
Refer to this link for build results: http://jenkins.cryptography.io/job/cryptography-pr-experimental/189/

Make SSL.py flake8 clean

alex reviewed Dec 24, 2013
View reviewed changes

reaperhulk added 11 commits December 25, 2013 09:10

initial commoncrypto backend. hash only

df63b81

some tests & temporary skip checks

88f0704

remove some unneeded internal detail for commondigest structs

1e45c1f

skip commoncrypto if not on darwin

0f71555

hashcontexts have algorithm as a public property

f437c97

initial backend docs

297d9f8

switch to namedtuple, add assert checks

6599329

remove unneeded skips now that markers are in place

c504f2e

try to load a list of backends. WIP

7395665

remove some unneeded methods now that we have markers

1d78548

add commoncrypto marker

3190ebe

skip whether or not it's parametrize with backend

5922ac3

reaperhulk added 2 commits January 2, 2014 22:52

refactor to split backend/bindings apart and match current master

baacef0

alex reviewed Jan 3, 2014
View reviewed changes

public reviewed Jan 3, 2014
View reviewed changes

reaperhulk added 3 commits January 3, 2014 09:48

remove unneeded extern keywords from function signatures on commoncrypto

3c57763

rework the namedtuple for hash methods

51576fb

reaperhulk mentioned this pull request Jan 4, 2014

Refactor bindings to reduce code duplication with multiple backends #403

Merged

reaperhulk added 3 commits January 4, 2014 13:18

commoncrypto binding now using new build_ffi method

50b5263

hash supported now requires an instantiated object

c8afb31

reaperhulk closed this Jan 10, 2014

reaperhulk deleted the common-crypto-base branch March 28, 2014 19:38

joerichter-stash pushed a commit to kiwigrid/cryptography that referenced this pull request Nov 15, 2017

Merge pull request pyca#344 from alex/ssl-flake8

cd57529

Make SSL.py flake8 clean

github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] CommonCrypto Initial #344

[WIP] CommonCrypto Initial #344

reaperhulk commented Dec 24, 2013

alex Dec 24, 2013

coveralls commented Dec 24, 2013

alex Dec 24, 2013

jenkins-cryptography commented Dec 24, 2013

jenkins-cryptography commented Dec 25, 2013

jenkins-cryptography commented Dec 25, 2013

coveralls commented Dec 25, 2013

coveralls commented Dec 25, 2013

jenkins-cryptography commented Dec 25, 2013

jenkins-cryptography commented Dec 28, 2013

coveralls commented Dec 28, 2013

alex Jan 3, 2014

alex Jan 3, 2014

coveralls commented Jan 3, 2014

jenkins-cryptography commented Jan 3, 2014

public Jan 3, 2014

alex commented Jan 4, 2014

reaperhulk commented Jan 4, 2014

alex commented Jan 4, 2014

coveralls commented Jan 4, 2014

jenkins-cryptography commented Jan 4, 2014

[WIP] CommonCrypto Initial #344

[WIP] CommonCrypto Initial #344

Conversation

reaperhulk commented Dec 24, 2013

alex Dec 24, 2013

Choose a reason for hiding this comment

coveralls commented Dec 24, 2013

alex Dec 24, 2013

Choose a reason for hiding this comment

jenkins-cryptography commented Dec 24, 2013

jenkins-cryptography commented Dec 25, 2013

jenkins-cryptography commented Dec 25, 2013

coveralls commented Dec 25, 2013

coveralls commented Dec 25, 2013

jenkins-cryptography commented Dec 25, 2013

jenkins-cryptography commented Dec 28, 2013

coveralls commented Dec 28, 2013

alex Jan 3, 2014

Choose a reason for hiding this comment

alex Jan 3, 2014

Choose a reason for hiding this comment

coveralls commented Jan 3, 2014

jenkins-cryptography commented Jan 3, 2014

public Jan 3, 2014

Choose a reason for hiding this comment

alex commented Jan 4, 2014

reaperhulk commented Jan 4, 2014

alex commented Jan 4, 2014

coveralls commented Jan 4, 2014

jenkins-cryptography commented Jan 4, 2014