Switch to jenkinsfile #3525

reaperhulk · 2017-04-29T14:40:27Z

This is very WIP and not ready for review at this time.

Outstanding tasks (in addition to "it needs to work"):

alex · 2017-05-10T12:25:26Z

Jenkins, retest this please

alex · 2017-05-22T18:14:03Z

Jenkinsfile

+
+
+def configs = [
+    /* [ */


These need to be uncommented :-)

alex · 2017-05-22T18:16:02Z

Jenkinsfile

+        label: 'docker',
+        imageName: 'pyca/cryptography-runner-fedora',
+        toxenvs: ['py27', 'py35'],
+    ],


We need the docs-linkcheck buidl somewhere, somehow.

alex · 2017-05-22T18:17:18Z

Jenkinsfile

+    def script = ""
+    if (env.BRANCH_NAME.startsWith('PR-')) {
+        script = """
+        git clone --depth=1 https://github.com/pyca/cryptography.git cryptography


Is it pratical to factor these first two lines of the script that are the same in both things out?

Do these need -xe? Or the #!?

alex · 2017-05-22T18:17:55Z

Jenkinsfile

+                            )
+                            if %TOXENV% == py36 (
+                                @set PYTHON="C:\\Python36\\python.exe"
+                            )


Can we put these values in a map outside the bat and just put $PYTHON in as an env var?

This question applies to all the if statements in here, doing the ifs in groovy seems way better.

alex · 2017-05-22T18:20:51Z

Jenkinsfile

+                                # Jenkins logs in as a non-interactive shell, so we don't even have /usr/local/bin in PATH
+                                export PATH=/usr/local/bin:\$PATH
+                                # pyenv is nothing but trouble with non-interactive shells
+                                #eval "\$(pyenv init -)"


Is this needed or not?

alex · 2017-05-22T18:21:12Z

Jenkinsfile

+                                export PATH="/Users/jenkins/.pyenv/shims:\${PATH}"
+                                export PYENV_SHELL=bash
+                                cd cryptography
+                                CRYPTOGRAPHY_OSX_NO_LINK_FLAGS=1 LDFLAGS="/usr/local/opt/openssl\\@1.1/lib/libcrypto.a /usr/local/opt/openssl\\@1.1/lib/libssl.a" CFLAGS="-I/usr/local/opt/openssl\\@1.1/include -Werror -Wno-error=deprecated-declarations -Wno-error=incompatible-pointer-types -Wno-error=unused-function -Wno-error=unused-command-line-argument" tox -r --  --color=yes


Split this across multiple lines so it's readable please

alex · 2017-05-22T18:21:39Z

Jenkinsfile

+                                set -xe
+                                cd cryptography
+                                if [[ "\${IMAGE_NAME}" == *"libressl"* ]]; then
+                                    LD_LIBRARY_PATH="/usr/local/libressl/lib:\$LD_LIBRARY_PATH" LDFLAGS="-L/usr/local/libressl/lib" CFLAGS="-I/usr/local/libressl/include" tox -r -- --color=yes


multiple lines.

alex · 2017-05-22T18:21:52Z

Jenkinsfile

+                                else
+                                    CFLAGS="" tox -vv -r -- --color=yes
+                                fi
+                                # In a perfect world this would be a separate stage. This is not a perfect world.


Make the comment explanatory or drop it please

alex · 2017-05-22T19:57:34Z

Jenkinsfile

+                            py36: "C:\\Python36\\python.exe"
+                        ]
+                        if (toxenv == "py35" || toxenv == "py36") {
+                            includeLib = [


This isn't a great name, how about opensslPaths?

Also, does it need a def

alex · 2017-05-22T19:57:40Z

Jenkinsfile

+                                "windows": [
+                                    "include": '"C:\\OpenSSL-Win32-2015\\include"',
+                                    "lib": '"C:\\OpenSSL-Win32-2015\\lib"'
+                                ], "windows64": [


Newline here.

alex · 2017-05-22T19:58:22Z

Jenkinsfile

+                        if (toxenv == "py35" || toxenv == "py36") {
+                            includeLib = [
+                                "windows": [
+                                    "include": '"C:\\OpenSSL-Win32-2015\\include"',


Is there a reason to put quotes in all these strings, rather than push it down?

alex · 2017-05-22T20:01:08Z

Jenkinsfile

+
+/* TODO */
+/* expand macOS testing */
+/* smoke tests */


These comments all need updating.

alex · 2017-05-22T21:36:08Z

Jenkinsfile

@@ -0,0 +1,328 @@
+/* known issues */
+/* Parallel tasks, when executed, show up as "part of <job name>" rather than a more descriptive name. See http://stackoverflow.com/questions/37812588/how-can-i-override-the-part-of-app-pipeline-buildname */


Remove this and turn it into a follow up issue, or linewrap it with a link to a jenkins upstream issue.

alex · 2017-05-22T21:36:20Z

Jenkinsfile

+/* Parallel tasks, when executed, show up as "part of <job name>" rather than a more descriptive name. See http://stackoverflow.com/questions/37812588/how-can-i-override-the-part-of-app-pipeline-buildname */
+
+/* notes */
+/* You must escape backslashes and $ because groovy. */


This can probably removed, it's just a fact of groovy.

* [WIP] add a jenkinsfile * various jenkinsfile fixes [ci skip] * experiments * escape the escaping * can't do that with /usr/bin/env bash * continue isolation * bleh * optimistically enable everything * things * add timeout, codecov * derp * sigh * add credentials for codecov upload * print the env * nonsense * checkout without jenkins because jenkins sucks * maybe we're not allowed to shadow * maybe if we actually pass the variable * scope * cd into a thing * also here * print the commit and run all the jobs again * son of a * add labels * ch-ch-ch-changes * damn it * add docs, pep8, py3pep8 * try some downstreams * make this maybe work * this is probably what we need * faster testing * run this in docker duh * delete me some dirs * wtf * god * more things * oh boy locales * re-enable everything, remove the locales now that they're embedded * refactor, this will probably break everything * small test * sigh * actually bind some variables. also rename things to be camelCase * oookay * this is not gonna work * test all the things * add docs-linkcheck, remove libre 2.5.3 because it is bad * syntax is for losers * append a thing * add yosemite, run this thing daily * oops * some finally cleanup * twisted is dead to us for a brief moment * add randomorder and setup.py test * whatever * re-enable twisted * delete everything. eat arby's * delete everything this time * all is emptiness

* Switch to jenkinsfile (#3525) * [WIP] add a jenkinsfile * various jenkinsfile fixes [ci skip] * experiments * escape the escaping * can't do that with /usr/bin/env bash * continue isolation * bleh * optimistically enable everything * things * add timeout, codecov * derp * sigh * add credentials for codecov upload * print the env * nonsense * checkout without jenkins because jenkins sucks * maybe we're not allowed to shadow * maybe if we actually pass the variable * scope * cd into a thing * also here * print the commit and run all the jobs again * son of a * add labels * ch-ch-ch-changes * damn it * add docs, pep8, py3pep8 * try some downstreams * make this maybe work * this is probably what we need * faster testing * run this in docker duh * delete me some dirs * wtf * god * more things * oh boy locales * re-enable everything, remove the locales now that they're embedded * refactor, this will probably break everything * small test * sigh * actually bind some variables. also rename things to be camelCase * oookay * this is not gonna work * test all the things * add docs-linkcheck, remove libre 2.5.3 because it is bad * syntax is for losers * append a thing * add yosemite, run this thing daily * oops * some finally cleanup * twisted is dead to us for a brief moment * add randomorder and setup.py test * whatever * re-enable twisted * delete everything. eat arby's * delete everything this time * all is emptiness * master builds should use the commit at the time it was merged (#3577) * Fixes #3573 -- archive the built docs in that builder (#3580) * Fixes #3573 -- archive the built docs in that builder * syntax * try it without this * I am an idiot * this is unused * uhh, let's try this * maybe this? * eh, html is the only thing * ffffuuuu * Ignore doctree * broader exclude * This works now * pin sphinx version to avoid test breakage (#3544) * fix compilation on 1.1.0f (#3603)

reaperhulk added 8 commits April 29, 2017 09:37

[WIP] add a jenkinsfile

aebf739

various jenkinsfile fixes [ci skip]

1c30eb9

experiments

bf7a86a

escape the escaping

4e28420

can't do that with /usr/bin/env bash

2e6eae5

continue isolation

f82e6df

bleh

f7acffc

optimistically enable everything

f445b3c

reaperhulk force-pushed the jenkinsfile branch from 2bca3e1 to f445b3c Compare May 10, 2017 00:58

reaperhulk added 20 commits May 10, 2017 15:05

things

ec9c205

add timeout, codecov

14b30f9

derp

10336db

sigh

abae2ae

add credentials for codecov upload

abdbb92

print the env

7b782f7

nonsense

ea68f04

checkout without jenkins because jenkins sucks

4209579

maybe we're not allowed to shadow

bf5c60b

maybe if we actually pass the variable

2404131

scope

988df78

cd into a thing

c209b0a

also here

cb28846

print the commit and run all the jobs again

bd013e1

son of a

e0f64f9

add labels

8fe644b

ch-ch-ch-changes

a745baa

damn it

5c19628

add docs, pep8, py3pep8

97de81f

try some downstreams

0f1aa88

reaperhulk added 3 commits May 21, 2017 16:32

sigh

ace1afd

actually bind some variables. also rename things to be camelCase

85189ff

oookay

715c63a

alex requested changes May 22, 2017

View reviewed changes

reaperhulk added 2 commits May 22, 2017 12:27

this is not gonna work

004bec5

test all the things

42d8f1b

alex requested changes May 22, 2017

View reviewed changes

reaperhulk added 5 commits May 22, 2017 13:22

add docs-linkcheck, remove libre 2.5.3 because it is bad

1825d27

syntax is for losers

efbf265

append a thing

d1fbbc3

add yosemite, run this thing daily

dd08e82

oops

775606f

alex requested changes May 22, 2017

View reviewed changes

reaperhulk added 2 commits May 22, 2017 14:40

some finally cleanup

e1ba67b

twisted is dead to us for a brief moment

bf94056

reaperhulk changed the title ~~[WIP] add a jenkinsfile~~ Switch to jenkinsfile May 22, 2017

reaperhulk added 4 commits May 22, 2017 15:17

add randomorder and setup.py test

813c8b6

whatever

de83db1

re-enable twisted

1f494e2

delete everything. eat arby's

4259be9

alex modified the milestone: Nineteenth Release May 23, 2017

reaperhulk added 2 commits May 22, 2017 17:03

delete everything this time

d64167b

all is emptiness

46eb081

alex approved these changes May 23, 2017

View reviewed changes

alex merged commit ba58e1f into pyca:master May 23, 2017

reaperhulk deleted the jenkinsfile branch May 23, 2017 01:11

github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switch to jenkinsfile #3525

Switch to jenkinsfile #3525

reaperhulk commented Apr 29, 2017 •

edited by alex

alex commented May 10, 2017

alex May 22, 2017

alex May 22, 2017

alex May 22, 2017

alex May 22, 2017

alex May 22, 2017

alex May 22, 2017

alex May 22, 2017

alex May 22, 2017

alex May 22, 2017

alex May 22, 2017

alex May 22, 2017

alex May 22, 2017

alex May 22, 2017

alex May 22, 2017

alex May 22, 2017

alex May 22, 2017

alex May 22, 2017

		@@ -0,0 +1,328 @@
		/* known issues */
		/* Parallel tasks, when executed, show up as "part of <job name>" rather than a more descriptive name. See http://stackoverflow.com/questions/37812588/how-can-i-override-the-part-of-app-pipeline-buildname */

Switch to jenkinsfile #3525

Switch to jenkinsfile #3525

Conversation

reaperhulk commented Apr 29, 2017 • edited by alex

alex commented May 10, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

reaperhulk commented Apr 29, 2017 •

edited by alex