add downstream tests for awslabs/aws-dynamodb-encryption-python #4280
Conversation
| cd aws-dynamodb-encryption-python | ||
| pip install -r test/requirements.txt | ||
| pip install -e . | ||
| pytest -m "local and not slow and not veryslow and not nope" -l |
There was a problem hiding this comment.
Haha, yup. Of the many levels of hypothesis-powered combinatorically exploding test scenarios, I figure we want the smallest set here.
|
The tests seem to be failing 👀 |
|
Yeah, was just digging through the logs (side note, might be worth revisiting the whitelisted Travis branches? makes it harder to run the CI on forks prior to a PR). Looks like it's choking on RSA-OAEP-SHA256, which requires OpenSSL >= 1.0.2. |
|
Oh gosh, it makes me so happy that our new downstream test harness makes it easy to swap OpenSSLs |
|
@mattsb42-aws for future reference we're totally okay with iterating a bit in a PR. A few build failures is fine. 😄 We have more parallel builders than your fork too so the jobs will run faster anyway. |
|
@reaperhulk Fair enough. I was under the impression that Travis ran fork CI in the context of the fork owner, so the builds for a fork wouldn't affect the main repo CI. |
|
@mattsb42-aws I cannot begin to tell you how much that wouldn't bother us :-) FWIW, we're not going to remove the branch restriction because otherwise every time I send a PR via the github edit-in-the-web UI, the tests get run twice and it makes @reaperhulk sad. |
|
@alex Haha, fair enough. I guess I could always just make an ephemeral branch on my fork that adds itself to the whitelist and gets constantly rebased on top of any branch I'm actually working on. Would be nice if the whitelist controls could be set per fork as well as per branch. |
…#4280) * add downstream tests for awslabs/aws-dynamodb-encryption-python * require recent OpenSSL for awslabs/dynamodb-encryption-python downstream tests
Add downstream tests for https://github.com/awslabs/aws-dynamodb-encryption-python