switch to twine check for verifying our readme renders on pypi #4623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
reviewed
Dec 2, 2018
| @@ -303,7 +303,7 @@ def run_tests(self): | |||
| "docstest": [ | |||
| "doc8", | |||
| "pyenchant >= 1.6.11", | |||
| "readme_renderer >= 16.0", | |||
There was a problem hiding this comment.
I think we still need this installed for twine check to do this?
There was a problem hiding this comment.
twine has readme_renderer as a dep now (and requires >= 21.0)
alex
approved these changes
Dec 2, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't love needing to make an sdist, but that's what twine check requires.
fixes #4523