Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PEP 517 to pyproject.toml #4783

Merged
merged 1 commit into from
Feb 28, 2019
Merged

Conversation

pganssle
Copy link
Contributor

This puts a new minimum on the PEP 518 requirement for setuptools because older versions of setuptools' PEP 517 backend will fail to include setup.py in an sdist.

I will note that the presence of pyproject.toml alone is enough to trigger PEP 517 in the latest version of pip, using the default backend, so regardless of whether or not build-backend is added to pyproject.toml, the bounds on setuptools need to be bumped (in pyproject.toml only).

@reaperhulk
Copy link
Member

So without this patch if setuptools happens to be older than 40.6 when creating an sdist via python setup.py sdist the setup.py won't be included in the sdist?

It looks like the comment in pyproject.toml about keeping the info in setup.py and this file in sync is no longer accurate (at least for setuptools) though?

@pganssle
Copy link
Contributor Author

So without this patch if setuptools happens to be older than 40.6 when creating an sdist via python setup.py sdist the setup.py won't be included in the sdist?

No, this is a bug with the PEP 517 build backend, so it will fail with tox or pep517.build or anything else that uses the PEP 517 build backend.

It's probably a pretty rare use case to build an sdist from source, but better safe than sorry.

@reaperhulk
Copy link
Member

Okay, got it. Could you update the comment about keeping the setup_requirements and this in sync that notes why setuptools versioning doesn't match? Other than that this LGTM.

This puts a new minimum on the PEP 518 requirement for `setuptools`
because older versions of setuptools' PEP 517 backend will fail to
include `setup.py` in an sdist.
@pganssle
Copy link
Contributor Author

pganssle commented Feb 27, 2019

@reaperhulk Updated, let me know if the comments need further changes.

mike-scott added a commit to mike-scott/zmp-manifest that referenced this pull request Feb 27, 2019
Cryptography 2.6 has a pip related bug which can break installations:
pyca/cryptography#4783

Will revert this once fixed.

Signed-off-by: Michael Scott <mike@foundries.io>
mike-scott added a commit to foundriesio/zmp-manifest that referenced this pull request Feb 28, 2019
Cryptography 2.6 has a pip related bug which can break installations:
pyca/cryptography#4783

Will revert this once fixed.

Signed-off-by: Michael Scott <mike@foundries.io>
@reaperhulk reaperhulk merged commit 0d30f5d into pyca:master Feb 28, 2019
@reaperhulk
Copy link
Member

For reference this PR was unrelated to the bug in cryptography 2.6 (which was an issue with wheel building resolved by re-releasing as 2.6.1 after correcting our wheel builder scripts)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants