Improve deprecation warning to specify the release #4804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The reason we didn't write an exact version there is that debian backported hmac.compare_digest to an earlier version iirc |
|
josepy test failures aren't your fault, they're certbot/josepy#47 |
alex
approved these changes
Mar 8, 2019
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
certbot/certbot#6827 (comment)
The warning yielded by this message was very confusing in the context of certbot-auto. It seemed to indicate I should upgrade to python 2.7, but as I was already using python 2.7 (via redhat scl), I, and others misunderstood what it was trying to say.