restore apis needed for a _ssl module when using cryptograhpy v2.7 #4969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattip
commented
Aug 15, 2019
| SSL_METHOD* (*SSLv3_server_method)(void) = NULL; | ||
| const SSL_METHOD* (*SSLv3_method)(void) = NULL; | ||
| const SSL_METHOD* (*SSLv3_client_method)(void) = NULL; | ||
| const SSL_METHOD* (*SSLv3_server_method)(void) = NULL; |
alex
reviewed
Aug 15, 2019
| @@ -44,6 +44,8 @@ | |||
|
|
|||
| X509_CRL *PEM_read_bio_X509_CRL(BIO *, X509_CRL **, pem_password_cb *, void *); | |||
|
|
|||
| X509 *PEM_read_bio_X509_AUX(BIO *, X509 **, pem_password_cb *, void *); | |||
There was a problem hiding this comment.
Can you drop this one. With python/cpython#15303 merge, it should be possibel to use PEM_read_bio_X509 in cryptography, which we already have.
There was a problem hiding this comment.
I will update the PR once I get a successful pypy build
|
PyPy also has Also one of our buildbots is running Ubuntu 14.04, which still needs |
|
We're still willing to help with this but since there's been no activity I'll close this for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyPy uses cryptography to implement a pure-python _ssl stdlib module. After upgrading to v2.7 of cryptography, it turns out some API wrappers were removed that PyPy needed.
@alex suggested we collaborate to ensure future compatibility. I am not sure you want all the cruft of the python _ssl implementation in this repo. Perhaps it makes more sense to provide a new pyca/_ssl repo that would include the tests from the cpython stdlib test suite?