Convert AESGCM AEAD to Rust #9181

alex · 2023-07-05T10:54:01Z

No description provided.

alex · 2023-07-05T11:45:22Z

Ok, LibreSSL is failing because:

rust-openssl has an assert, when you set an IV, that the iv.len() <= EVP_CIPHER_CTX_iv_length()
On LibreSSL EVP_CIPHER_CTX_iv_length always returns the cipher's length, it does not respect EVP_CTRL_AEAD_SET_IVLEN
The cipher's length is 12.
Therefore using an IV shorter than 12 bytes will always hit this assert on LibreSSL

Not immediately sure what the right fix it. This feels like a LibreSSL bug, but would take a while to roll out.

alex · 2023-07-05T11:50:49Z

Looks like BoringSSL will have this same problem.

alex · 2024-01-13T01:47:42Z

Ok this is now green, minus LibreSSL 3.7.3, meaning that we're waiting for May 1 when the relevant OpenBSD version is dropped.

reaperhulk · 2024-01-28T22:17:55Z

Presented without comment:

alex force-pushed the aead-rust branch from 33321a9 to f0e44f6 Compare July 5, 2023 11:02

alex force-pushed the aead-rust branch from f0e44f6 to eda806f Compare July 7, 2023 01:29

alex mentioned this pull request Jul 7, 2023

Migrate backend to rust #8770

Open

22 tasks

alex force-pushed the aead-rust branch from eda806f to f5922ce Compare July 29, 2023 16:20

alex force-pushed the aead-rust branch 3 times, most recently from ae2be04 to 0885437 Compare August 14, 2023 12:51

alex force-pushed the aead-rust branch 2 times, most recently from bc2acc0 to 9c81b3c Compare August 27, 2023 16:30

alex force-pushed the aead-rust branch 3 times, most recently from 8ec3e30 to 4677a1f Compare September 12, 2023 21:44

alex force-pushed the aead-rust branch 2 times, most recently from 4b45717 to 12b90fb Compare September 14, 2023 00:06

alex marked this pull request as draft September 14, 2023 12:31

alex force-pushed the aead-rust branch 2 times, most recently from 5f9c81a to ccdfc52 Compare September 19, 2023 18:17

alex force-pushed the aead-rust branch 2 times, most recently from 7134cc7 to e100499 Compare November 4, 2023 05:30

alex force-pushed the aead-rust branch from e100499 to c3c28d2 Compare November 24, 2023 21:45

alex added the blocked-on-upstream label Nov 25, 2023

alex force-pushed the aead-rust branch from c3c28d2 to 017dbe1 Compare December 2, 2023 22:05

alex force-pushed the aead-rust branch 5 times, most recently from 4b51aa4 to 961e284 Compare January 13, 2024 01:44

jlaine mentioned this pull request Jan 17, 2024

Migrate AESGCM to Rust #10196

Closed

Convert AESGCM AEAD to Rust

a48e1e3

alex force-pushed the aead-rust branch from 961e284 to a48e1e3 Compare January 28, 2024 22:01

alex marked this pull request as ready for review January 28, 2024 22:04

reaperhulk approved these changes Jan 28, 2024

View reviewed changes

reaperhulk merged commit ea5a5b4 into pyca:main Jan 28, 2024
57 checks passed

alex deleted the aead-rust branch January 28, 2024 22:19

Provide feedback