Add timezone-aware API variants for x509 #9661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facutuesca
force-pushed
the
timezone-aware-x509-apis
branch
from
1be74e6
to
be8e068
Compare
facutuesca
force-pushed
the
timezone-aware-x509-apis
branch
from
be8e068
to
ba08d96
Compare
alex
reviewed
Sep 28, 2023
facutuesca
force-pushed
the
timezone-aware-x509-apis
branch
from
565d90f
to
5f8ae80
Compare
@alex Done! |
reaperhulk
reviewed
Sep 28, 2023
| @@ -376,6 +376,18 @@ X.509 Certificate Object | |||
| >>> cert.not_valid_before | |||
| datetime.datetime(2010, 1, 1, 8, 30) | |||
|
|
|||
| .. attribute:: not_valid_before_utc | |||
|
|
|||
There was a problem hiding this comment.
These new attributes need .. versionadded:: 42.0.0
facutuesca
force-pushed
the
timezone-aware-x509-apis
branch
from
5f8ae80
to
0db9022
Compare
reaperhulk
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PRs adds timezone-aware variants for the following properties:
x509.Certificate.not_valid_beforeandx509.Certificate.not_valid_afterx509.RevokedCertificate.revocation_datex509.CertificateRevocationList.last_updateandx509.CertificateRevocationList.next_updateThe variants have the same name with
_utcappended (i.e:not_valid_before->not_valid_before_utc).These variants return a
datetime.datetimeobject with the timezone set to UTC. Sincecryptographyalready internally converted these datetimes to UTC, we only need to return the same object with the timezone set.This is part of #9186: providing the timezone-aware variants is the step before deprecating the naive APIs.