Python 3 porting fixes #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason for mixing these unrelated things together is that Twisted supports only Python 3.3, not Python 3.2, and my Python 3.3 build apparently tripped over all of the same issues that the OS X "brewed" Python from #3 tripped over. |
|
travis-ci just reminded me that this will require cryptography 0.2. |
exarkun
added a commit
that referenced
this pull request
Jan 20, 2014
Correct some mistakes made during earlier Python 3 porting work. Mainly, keep accepting both bytes and unicode in a few APIs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address #3 as well as some compatibility problems pointed out by Twisted's test suite.
The gist of this branch is loosening of the requirements that values which only make sense as sequences of bytes be represented using the
bytestype only. Instead, a text type is now allowed and converted to bytes using either UTF-8 (filenames) or ASCII (everything else).