Add Elliptic Curve support to PKey #195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 similar comments
Add support for TYPE_EC to PKey Add tests for TYPE_EC PKey Add documentation for TYPE_EC PKey Add ChangeLog entry for TYPE_EC PKey Pick some curves for the test_regeneration
1 similar comment
| :param type: The key type (TYPE_RSA or TYPE_DSA) | ||
| :param bits: The number of bits | ||
| :param type: The key type (TYPE_RSA or TYPE_DSA or TYPE_EC) | ||
| :param bits: The number of bits or EllipticCurve |
There was a problem hiding this comment.
If I was specifying a curve, I'm not sure if I would know how I would do it, based on this. If I was using RSA I would specify something like "2048". If I was specifying a curve, I would specify what? "secp384r1"? I'm not sure if I have a better alternative though or a suggestion for where you should take it.
There was a problem hiding this comment.
I agree, it's not the greatest approach.
The current implementation is used as follows:
curve = OpenSSL.crypto.get_elliptic_curve('secp384r1')
pkey = PKey()
pkey.generate(key, TYPE_EC, curve)
Honestly I think the best approach would be to subclass PKey into RSAPKey, DSAPKey, and ECPKey but that is getting away from the thin abstraction on top of OpenSSL.
|
I believe this has been fixed via #439. Sorry for the inappropriate process! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rewrite of an older PR that adds EC support to PKey to incorporate the inclusion of _EllipticCurve objects.