Fix the WantWriteError test on OS X #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fill it. This makes the test pass on OS X. Previously it failed with the wrong exception type probably because there was enough room left in the send buffer for the handshake to start.
|
FWIW, all tox tests pass for me now on OS X 10.9. |
|
Thanks for the feedback hynek! |
exarkun
added a commit
that referenced
this pull request
Feb 22, 2014
Fix the WantWriteError test on OS X (purely a test bug).
kouk
added a commit
to kouk/pyopenssl
that referenced
this pull request
Feb 24, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #8.