Merged
Conversation
This reverts commit 6ef8a4c.
Co-authored-by: Brandon Bocklund <brandonbocklund@gmail.com>
Co-authored-by: Brandon Bocklund <brandonbocklund@gmail.com>
Co-authored-by: Brandon Bocklund <brandonbocklund@gmail.com>
Co-authored-by: Brandon Bocklund <brandonbocklund@gmail.com>
Co-authored-by: Brandon Bocklund <brandonbocklund@gmail.com>
Co-authored-by: Brandon Bocklund <brandonbocklund@gmail.com>
Co-authored-by: Brandon Bocklund <brandonbocklund@gmail.com>
Co-authored-by: Brandon Bocklund <brandonbocklund@gmail.com>
Co-authored-by: Brandon Bocklund <brandonbocklund@gmail.com>
Co-authored-by: Brandon Bocklund <brandonbocklund@gmail.com>
Co-authored-by: Brandon Bocklund <brandonbocklund@gmail.com>
Co-authored-by: Brandon Bocklund <brandonbocklund@gmail.com>
Co-authored-by: Brandon Bocklund <brandonbocklund@gmail.com>
This reverts commit 82e1620.
…d on 'renderer_framework' branch.
bocklund
reviewed
Jul 14, 2024
Co-authored-by: Brandon Bocklund <brandonbocklund@gmail.com>
bocklund
approved these changes
Jul 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workspaceobject and associated imperative API. This object now underlies theequilibriumfunction, which remains for backwards compatibility. AWorkspaceobject can be mutated after creation. TheWorkspace.get()function acceptsComputablePropertyobjects as input and returns arrays. Fixes Develop a wrapper API for plotting properties from calculate and equilibrium #154PhaseRecordFactoryobject and associated connections toPhaseRecord, which enables deferred compilation of symbolically-defined model properties until they are called in thePhaseRecordAPI. ThePhaseRecordobject also gainspropandprop_gradfunctions for computing properties and property gradients of arbitrary symbolic attributes ofModelinstances.IsolatedPhaseandDormantPhasemeta-properties. Meta-properties are objects that know how to create new properties (as defined by the CPF). In this case, these meta-properties know how to start sub-calculations . The current way of finding starting points for these calculations is not ideal and prone to failure (basically reusesCompositionSetobjects from the workspace equilibrium calculation), but it works well in the typical case.pint. AllComputablePropertyobjects have "implementation units" and "display units." Implementation units are what are assumed by the underlying numerical computation (which is done without units, for performance). The display units are what the user gets whenWorkspace.getis called.ComputableProperty.__getitem__allows the display units to be changed for individual calls toWorkspace.get, or when settingWorkspace.conditions.Workspace.getbuild_phase_recordsis removed. Use thePhaseRecord.prop_*API in downstream functions instead.Documentation
setup.py(runtime requirements)