forked from richardotis/pycalphad
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: a few minor fixes to Workspace workflows
- Loading branch information
Showing
3 changed files
with
3 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -108,7 +108,7 @@ def add_nearly_stable(object composition_sets, object phase_records, | |
# Add unrepresented phases as metastable composition sets | ||
# This should help catch phases around the limit of stability | ||
for phase_name in sorted(phase_records.keys()): | ||
if phase_name in entered_phases: | ||
if phase_name in entered_phases or grid.attrs['phase_indices'].get(phase_name, True): | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
sorkins
Author
Owner
|
||
continue | ||
phase_record = phase_records[phase_name] | ||
phase_indices = grid.attrs['phase_indices'][phase_name] | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change has the effect of completely disabling
add_nearly_stable
(it should always evaluate toTrue
, so the whole loop is skipped). Did you do this to mitigate an issue similar to pycalphad#503 ? If so, the underlying bug is now fixed in pycalphad#432, so please try it again. If not, can you share a test case for the problem you are encountering with this function?