Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] in tune model for snaive and grand_means in time series #1812

Closed
ngupta23 opened this issue Nov 7, 2021 · 0 comments
Closed

[BUG] in tune model for snaive and grand_means in time series #1812

ngupta23 opened this issue Nov 7, 2021 · 0 comments
Assignees
@ngupta23
Labels
bug Something isn't working models time_series Topics related to the time series tune_model
Projects
Time Series Forecasting
Milestone
Time Series Gamma...

Comments

@ngupta23
Copy link
Collaborator

ngupta23 commented Nov 7, 2021

You may have to override eq_function attr to make sure that it doesn't clash with the regular naive forecaster

Originally posted by @Yard1 in #1806 (comment)

In tune models, since the base class is the same for naive, snaive and grand_means, when we tune snaive and grand_means, it uses the grid from naive instead of using their own respective grids.
@ngupta23 ngupta23 self-assigned this Nov 7, 2021
@ngupta23 ngupta23 added time_series Topics related to the time series bug Something isn't working tune_model models labels Nov 7, 2021
@ngupta23 ngupta23 added this to To do in Time Series Forecasting via automation Nov 7, 2021
@ngupta23 ngupta23 added this to the Time Series Gamma Release milestone Nov 7, 2021
@ngupta23 ngupta23 mentioned this issue Nov 7, 2021
Open
ngupta23 added a commit that referenced this issue Nov 9, 2021
@ngupta23
fix per #1812
164929e
@ngupta23 ngupta23 mentioned this issue Nov 9, 2021
Merged
ngupta23 added a commit that referenced this issue Nov 17, 2021
@ngupta23
fix to eq functions for naive models per #1812
f73103a
@ngupta23 ngupta23 mentioned this issue Nov 17, 2021
Merged
13 tasks
ngupta23 added a commit that referenced this issue Nov 18, 2021
@ngupta23
Merge pull request #1860 from pycaret/ts_eq_func
e6f0263 
fix to eq functions for naive models per #1812
Time Series Forecasting automation moved this from To do to Done Nov 18, 2021
@ngupta23 ngupta23 changed the title Bug in tune model for snaive and grand_means in time series [BUG] in tune model for snaive and grand_means in time series Nov 18, 2021
@ngupta23 ngupta23 mentioned this issue Dec 2, 2021
Merged
13 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ngupta23 ngupta23

Labels
bug Something isn't working models time_series Topics related to the time series tune_model
Projects
Time Series Forecasting
Done
Milestone
Time Series Gamma Release
Development

No branches or pull requests
1 participant
@ngupta23