Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] CdsDt Models in Time Series do not take sp into account in create model #1846

Closed
ngupta23 opened this issue Nov 13, 2021 · 0 comments
Closed

[BUG] CdsDt Models in Time Series do not take sp into account in create model #1846

ngupta23 opened this issue Nov 13, 2021 · 0 comments
Assignees
@ngupta23
Labels
bug Something isn't working models time_series Topics related to the time series
Projects
Time Series Forecasting
Milestone
Time Series Gamma...

Comments

@ngupta23
Copy link
Collaborator 

lr_model = exp.create_model("lr_cds_dt")
lr_model._forecaster.named_steps  # should have been sp = 12 for airline dataset

image
@ngupta23 ngupta23 added bug Something isn't working time_series Topics related to the time series models labels Nov 13, 2021
@ngupta23 ngupta23 added this to the Time Series Gamma Release milestone Nov 13, 2021
@ngupta23 ngupta23 self-assigned this Nov 13, 2021
@ngupta23 ngupta23 added this to To do in Time Series Forecasting via automation Nov 13, 2021
@ngupta23 ngupta23 mentioned this issue Nov 13, 2021
Open
ngupta23 added a commit that referenced this issue Nov 17, 2021
@ngupta23
improved default grid definition for CdsCt per #1846
223ff0e
@ngupta23 ngupta23 mentioned this issue Nov 17, 2021
Merged
13 tasks
ngupta23 added a commit that referenced this issue Nov 17, 2021
@ngupta23
Merge pull request #1861 from pycaret/ts_cds_dt_fix
9d352e7 
improved default grid definition for CdsCt per #1846
Time Series Forecasting automation moved this from To do to Done Nov 17, 2021
@ngupta23 ngupta23 mentioned this issue Dec 2, 2021
Merged
13 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ngupta23 ngupta23

Labels
bug Something isn't working models time_series Topics related to the time series
Projects
Time Series Forecasting
Done
Milestone
Time Series Gamma Release
Development

No branches or pull requests
1 participant
@ngupta23