Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove references to import * in code #2423

Closed
ngupta23 opened this issue Apr 18, 2022 · 2 comments · Fixed by #2433
Closed

Remove references to import * in code #2423

ngupta23 opened this issue Apr 18, 2022 · 2 comments · Fixed by #2433
Assignees
@NeptuneN
Labels
enhancement New feature or request good first issue Good for newcomers refactor
Projects
PyCaret Refactor
Milestone
pycaret 3.0.0rc1

Comments

@ngupta23
Copy link
Collaborator

ngupta23 commented Apr 18, 2022 •
edited

Is your feature request related to a problem? Please describe.

Remove references to the following in the code base and replace with the appropriate explicit imports.

from pycaret.internal.validation import *

NOTE: If doing this before the 3.0.0 release, changes should go into the time_series branch. If doing this after the 3.0.0 release, then changes should go into the (yet to be created) develop branch.
@ngupta23 ngupta23 added enhancement New feature or request good first issue Good for newcomers refactor labels Apr 18, 2022
@ngupta23 ngupta23 added this to the pycaret 3.1.0 milestone Apr 18, 2022
NeptuneN added a commit to NeptuneN/pycaret that referenced this issue Apr 18, 2022
@NeptuneN
Address issue pycaret#2423
e538cc3
@NeptuneN NeptuneN mentioned this issue Apr 18, 2022
Closed
13 tasks
NeptuneN added a commit to NeptuneN/pycaret that referenced this issue Apr 18, 2022
@NeptuneN
Refactor import * reference to only import necessary functions pycare…
d673630 
…t#2423
@NeptuneN
Copy link
Contributor

NeptuneN commented Apr 18, 2022 •
edited

Hello! Could I pick up this issue?

@NeptuneN NeptuneN mentioned this issue Apr 18, 2022
Merged
13 tasks
@ngupta23 ngupta23 linked a pull request Apr 18, 2022 that will close this issue
Refactor import * reference to only import necessary functions #2423 #2433
Merged
13 tasks
@ngupta23 ngupta23 mentioned this issue Apr 18, 2022
Closed
ngupta23 added a commit that referenced this issue Apr 18, 2022
@ngupta23
Merge pull request #2433 from NeptuneN/time_series
9c64a2d 
Refactor import * reference to only import necessary functions #2423
@ngupta23 ngupta23 added this to To do in PyCaret Refactor via automation Apr 18, 2022
@ngupta23 ngupta23 modified the milestones: pycaret 3.1.0, pycaret 3.0.0 Apr 18, 2022
PyCaret Refactor automation moved this from To do to Done Apr 18, 2022
@ngupta23
Copy link
Collaborator Author

@NeptuneN Awesome. Thanks for your first contribution to the project.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NeptuneN NeptuneN

Labels
enhancement New feature or request good first issue Good for newcomers refactor
Projects
PyCaret Refactor
Done
Milestone
pycaret 3.0.0rc1
Development

Successfully merging a pull request may close this issue.

Refactor import * reference to only import necessary functions #2423 NeptuneN/pycaret
2 participants
@ngupta23 @NeptuneN