Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time Series (create_model) - Initial PR #1068

Merged
merged 64 commits into from Feb 28, 2021
Merged

Time Series (create_model) - Initial PR #1068

merged 64 commits into from Feb 28, 2021

Conversation

ngupta23
Copy link
Collaborator

@ngupta23 ngupta23 commented Feb 14, 2021

Related Issuse or bug

  • Initial PR for create_models for time series (Work in Progress)

Describe the changes you've made

  • Initial PR for create_models for time series

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots

Original Updated
original screenshot updated screenshot

@Yard1 Yard1 changed the base branch from master to time_series February 14, 2021 18:30
@Yard1
Copy link
Member

Yard1 commented Feb 14, 2021

I have merged time_series into this branch to take care of the X,y ordering issue using a new internal pipeline.

Just one nitpick - instead of doing isinstance() on self, compare self._ml_usecase to eg. MLUsecase.TIME_SERIES. That way imports handle better and the code is clearer.

@ngupta23
Copy link
Collaborator Author

Updates:

Splitters

  • Only supporting SlidingWindowSplitter and ExpandingWindowSplitter right now.
  • Not supporting timeseries splitter for now. might add back later

fh

  • If integer, then forecasts that many time points ahead
    • e.g. fh = 12 will forecast from [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12] points ahead
  • If list, then forecasts only those points (this needs to be tested further)
    • e.g. fh = [1, 4, 7] will forecast from only 3 points that are 1 time point, 4 time points and 7 time points ahead
  • If numpy.array, then similar to list

Metrics

  • Reduced metrics to only 2 for now. Needed to do this so it could work with custom cross_validate_ts function.
  • Need to fix this in the long run.
  • Will add more later

TBD

  • add unit tests for create_model. Will add in a separate PR.
  • Let's get this merged so other development can happen in parallel. I will add the unit tests right away in parallel.

@ngupta23 ngupta23 marked this pull request as ready for review February 28, 2021 16:32
Copy link
Contributor

@TremaMiguel TremaMiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @ngupta23 just added a pair of comments.

test_time_series.py Show resolved Hide resolved
pycaret/internal/PycaretExperiment.py Show resolved Hide resolved
pycaret/internal/PycaretExperiment.py Show resolved Hide resolved
@Yard1 Yard1 merged commit 6f9c3bb into time_series Feb 28, 2021
@ngupta23 ngupta23 deleted the time_series_ng branch March 1, 2021 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants