Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: compare time series models #1174

Merged
merged 12 commits into from Apr 18, 2021
Merged

feat: compare time series models #1174

merged 12 commits into from Apr 18, 2021

Conversation

TremaMiguel
Copy link
Contributor

Describe the changes you've made

Major changes include:

  • compare_models() support for time series models.
  • create_model_without_cv switching X, y order before fitting estimator. link

Minor changes include:

  • change sktime requirement to version 0.5.3, sktime version 0.6.0 changes functionality in ExpandingWindowSplitter.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

No tests added

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Copy link
Collaborator

@ngupta23 ngupta23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just change the default metric to smape and resolve the conflict with my branch and should be good to go.

pycaret/internal/PycaretExperiment.py Outdated Show resolved Hide resolved
pycaret/internal/PycaretExperiment.py Outdated Show resolved Hide resolved
pycaret/time_series.py Outdated Show resolved Hide resolved
Copy link
Member

@Yard1 Yard1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just this one - we should avoid using lambda functions unless they are really tiny

@@ -5136,8 +5136,11 @@ def compare_models(
display.display_monitor()
display.display_master_display()

# pull() method retrieves metrics id to column the results
id_or_display_name = lambda x: x.id if self._ml_usecase == MLUsecase.TIME_SERIES else x.display_name
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please turn this into a normal function (with def)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refactor to id_or_display_name function

@ngupta23 ngupta23 self-requested a review April 18, 2021 11:14
@Yard1 Yard1 merged commit 1b3854a into time_series Apr 18, 2021
@TremaMiguel TremaMiguel deleted the ts_compare_mmodels branch April 18, 2021 17:10
@ngupta23 ngupta23 added time_series Topics related to the time series and removed time_series_dev labels Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
time_series Topics related to the time series
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants