Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Prophet model #1279

Merged
merged 32 commits into from Jun 21, 2021
Merged

feat: Prophet model #1279

merged 32 commits into from Jun 21, 2021

Conversation

TremaMiguel
Copy link
Contributor

Describe the changes you've made

Major changes include:

  1. Add Prophet Container. link
  2. freq parameter in datetime index is not preserved for more than two folds. Thus, store Index.freqstr in setup and convert frequency in data splits. link

Minor changes include:

  1. Accept pandas DatetimeIndex as valid time index. link

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

No new tests added, change data to timestamp when testing prophet model. link

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@TremaMiguel TremaMiguel changed the title Prophet model feat: Prophet model May 22, 2021
@Yard1
Copy link
Member

Yard1 commented May 22, 2021

There's a test issue with importing prophet on windows CI, can you check? @TremaMiguel

pycaret/containers/models/time_series.py Outdated Show resolved Hide resolved
pycaret/containers/models/time_series.py Outdated Show resolved Hide resolved
requirements-ts.txt Outdated Show resolved Hide resolved
Copy link
Member

@Yard1 Yard1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions regarding prophet tune grids

pycaret/containers/models/time_series.py Outdated Show resolved Hide resolved
pycaret/containers/models/time_series.py Outdated Show resolved Hide resolved
@Yard1
Copy link
Member

Yard1 commented Jun 12, 2021

Just gotta make CI pass

@ngupta23 ngupta23 added this to In progress in Time Series Forecasting via automation Jun 18, 2021
@@ -43,6 +43,15 @@
warnings.filterwarnings("ignore")
LOGGER = get_logger()

DATETIME_INDEX_MODELS = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @TremaMiguel Will you revert back this change. It should not be needed with if you are converting the datetime_index to period_index to all models in setup and handling Prophet using the wrapper.

@Yard1 Yard1 merged commit 7e37197 into time_series Jun 21, 2021
Time Series Forecasting automation moved this from In progress to Done Jun 21, 2021
@TremaMiguel TremaMiguel deleted the prophet_model branch June 22, 2021 00:36
@ngupta23 ngupta23 added time_series Topics related to the time series and removed time_series_dev labels Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
time_series Topics related to the time series
Development

Successfully merging this pull request may close these issues.

None yet

3 participants