New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Prophet model #1279
feat: Prophet model #1279
Conversation
There's a test issue with importing prophet on windows CI, can you check? @TremaMiguel |
Co-authored-by: Antoni Baum <antoni.baum@protonmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestions regarding prophet tune grids
Just gotta make CI pass |
@@ -43,6 +43,15 @@ | |||
warnings.filterwarnings("ignore") | |||
LOGGER = get_logger() | |||
|
|||
DATETIME_INDEX_MODELS = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @TremaMiguel Will you revert back this change. It should not be needed with if you are converting the datetime_index to period_index to all models in setup and handling Prophet using the wrapper.
Describe the changes you've made
Major changes include:
freq
parameter in datetime index is not preserved for more than two folds. Thus, storeIndex.freqstr
in setup and convert frequency in data splits. linkMinor changes include:
DatetimeIndex
as valid time index. linkType of change
Please delete options that are not relevant.
How Has This Been Tested?
No new tests added, change data to timestamp when testing
prophet
model. linkChecklist: