Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fold Strategy Updates #1282

Merged
merged 3 commits into from May 23, 2021
Merged

Fold Strategy Updates #1282

merged 3 commits into from May 23, 2021

Conversation

ngupta23
Copy link
Collaborator

Describe the changes you've made

Previously, time series experiment only accepted a string as input for fold_strategy. With this change, it can also accept a sktime compatible cv object directly. If an object is passed, then the fold and fh parameters in setup are ignored and are extracted from the cv object directly.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Updated unit tests

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

None

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@ngupta23 ngupta23 added this to In progress in Time Series Forecasting via automation May 23, 2021
@ngupta23 ngupta23 merged commit 855bede into time_series May 23, 2021
Time Series Forecasting automation moved this from In progress to Done May 23, 2021
@ngupta23 ngupta23 added time_series Topics related to the time series and removed time_series_dev labels Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
time_series Topics related to the time series
Development

Successfully merging this pull request may close these issues.

None yet

2 participants