Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finalize_model #1340

Merged
merged 2 commits into from Jun 9, 2021
Merged

finalize_model #1340

merged 2 commits into from Jun 9, 2021

Conversation

ngupta23
Copy link
Collaborator

@ngupta23 ngupta23 commented Jun 8, 2021

Describe the changes you've made

Cleaned up finalize_model and added unit tests

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Unit tests have been updated

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@ngupta23
Copy link
Collaborator Author

ngupta23 commented Jun 9, 2021

I will go ahead and merge this since the changes are straightforward.

@ngupta23 ngupta23 merged commit ed0474e into time_series Jun 9, 2021
@ngupta23 ngupta23 deleted the ts_finalize_model branch June 10, 2021 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants