Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more updates to make sktime 0.7.0 compatible. Disabled ensemble/blend for now #1466

Merged
merged 2 commits into from
Jul 23, 2021

Conversation

ngupta23
Copy link
Collaborator

Related Issuse or bug

Fixes: #1369

Describe the changes you've made

  • Disabled Ensemble / Blending (@TremaMiguel) to have a look at this
  • Fixed splitters
  • Fixed reduced regression models

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Old unit tests are passing as expected (except blend tests which have been disabled for now)

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Copy link
Member

@Yard1 Yard1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Will wait for @TremaMiguel

@ngupta23 ngupta23 changed the title more updated to make sktime 0.7.0 compatible. Disabled ensemble/blend for now more updates to make sktime 0.7.0 compatible. Disabled ensemble/blend for now Jul 23, 2021
@TremaMiguel TremaMiguel merged commit 3915046 into ts_sktime_0p7 Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants