Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[timeseries] Fix_fit_and_score metrics not getting their kwargs #1512

Merged
merged 3 commits into from Aug 14, 2021

Conversation

Yard1
Copy link
Member

@Yard1 Yard1 commented Aug 14, 2021

Related Issuse or bug

  • Info about Issue or bug

Fixes: #[issue number that will be closed through this PR]

Describe the changes you've made

Fixes the _fit_and_score method in time series not passing metric kwargs to function calls, leading to inaccurate metric values.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots

Original Updated
original screenshot updated screenshot

@ngupta23 ngupta23 merged commit 06acc7c into time_series Aug 14, 2021
@ngupta23 ngupta23 deleted the time_series_fix_fit_and_score_metric_kwargs branch August 14, 2021 16:49
@ngupta23 ngupta23 added time_series Topics related to the time series and removed time_series_dev labels Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
time_series Topics related to the time series
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants