Multiple Time Series Fixes and Enhancements #1585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nified setting of fh in all functions.
ngupta23
requested review from
Yard1,
satya-pattnaik,
TremaMiguel and
moezali1
Yard1
approved these changes
Sep 19, 2021
Comment on lines
+34
to
+44
| elif plot == "train_test_split": | ||
| plot_data = plot_splits_tt( | ||
| train=train, test=test, return_data=return_data, show=show | ||
| ) | ||
| elif plot == "splits_cv": | ||
| plot_data = plot_splits_cv(data=data, cv=cv, return_data=return_data, show=show) | ||
| elif plot == "cv": | ||
| plot_data = plot_cv(data=data, cv=cv, return_data=return_data, show=show) | ||
| elif plot == "acf": | ||
| plot_data = plot_acf(data=data, return_data=return_data, show=show) | ||
| elif plot == "pacf": | ||
| plot_data = plot_pacf(data=data, return_data=return_data, show=show) | ||
| elif plot == "predictions": | ||
| elif plot == "forecast": |
There was a problem hiding this comment.
Is this somewhere in the documentation? If so, has it been updated?
There was a problem hiding this comment.
@moezali1 will update the documentation before the next release.
ngupta23
added
time_series
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issuse or bug
#1566
#1564
#1563
#1562
#1560
#1559
#1557
#1555
Fixes: #[issue number that will be closed through this PR]
#1566
#1564
#1563
#1562
#1560
#1559
#1557
#1555
Describe the changes you've made
Enhancements and fixes made as per issues
Type of change
How Has This Been Tested?
Unit tests updated as necessary and rerun locally
Describe if there is any unusual behaviour of your code(Write
NAif there isn't)N/A
Checklist: