Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to enforce Predicton Interval #1662

Merged
merged 8 commits into from Oct 8, 2021
Merged

Option to enforce Predicton Interval #1662

merged 8 commits into from Oct 8, 2021

Conversation

ngupta23
Copy link
Collaborator

@ngupta23 ngupta23 commented Oct 8, 2021

Related Issuse or bug

Describe the changes you've made

Added option to enforce use of models that have a prediction interval only.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Unit tests added/updated

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@ngupta23 ngupta23 added the time_series Topics related to the time series label Oct 8, 2021
@ngupta23 ngupta23 added this to In progress in Time Series Forecasting via automation Oct 8, 2021
@ngupta23 ngupta23 added this to the Time Series Beta Release milestone Oct 8, 2021
@ngupta23 ngupta23 linked an issue Oct 8, 2021 that may be closed by this pull request
[Time Series] Limit models to only those that have a prediction interval #1437
Closed
Yard1
Yard1 requested changes Oct 8, 2021
View reviewed changes
pycaret/containers/models/time_series.py
@@ -234,6 +234,12 @@ def __init__(self, globals_dict: dict) -> None:

from sktime.forecasting.naive import NaiveForecaster # type: ignore

dummy = NaiveForecaster()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering that this code block is reused many times, can we make it a function/method?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Please check

@ngupta23 ngupta23 requested a review from Yard1 October 8, 2021 22:34
@ngupta23 ngupta23 mentioned this pull request Oct 8, 2021
Merged
13 tasks
Yard1
Yard1 approved these changes Oct 8, 2021
View reviewed changes
Copy link
Member

@Yard1 Yard1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ngupta23 ngupta23 merged commit 813df5f into time_series Oct 8, 2021
Time Series Forecasting automation moved this from In progress to Done Oct 8, 2021
@ngupta23 ngupta23 deleted the ts_enforce_pi branch October 9, 2021 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yard1 Yard1 Yard1 approved these changes

@satya-pattnaik satya-pattnaik Awaiting requested review from satya-pattnaik

Assignees
No one assigned
Labels
time_series Topics related to the time series
Projects
Time Series Forecasting
Done
Milestone
Time Series Beta Release
Development

Successfully merging this pull request may close these issues.

[Time Series] Limit models to only those that have a prediction interval
2 participants
@ngupta23 @Yard1