Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time Series changed X to integer based indexing in _fit_and_score #2108

Merged
merged 1 commit into from Jan 31, 2022

Conversation

ngupta23
Copy link
Collaborator

Describe the changes you've made

Minor bug in exogenous handling in _fit_and_predict. Needed to change from loc to iloc since train and test indices returned by cv splitter are integer based.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Unit tests to be rerun on GitHub

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@ngupta23 ngupta23 added bug Something isn't working time_series Topics related to the time series multivariate labels Jan 31, 2022
@ngupta23 ngupta23 added this to the Time Series 202202 Release milestone Jan 31, 2022
@ngupta23 ngupta23 added this to In progress in Time Series Forecasting via automation Jan 31, 2022
@ngupta23 ngupta23 merged commit 44ca189 into time_series Jan 31, 2022
Time Series Forecasting automation moved this from In progress to Done Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working exogenous time_series Topics related to the time series
Development

Successfully merging this pull request may close these issues.

None yet

1 participant