Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making rendering of plots faster #2164

Merged
merged 3 commits into from Feb 15, 2022
Merged

Making rendering of plots faster #2164

merged 3 commits into from Feb 15, 2022

Conversation

ngupta23
Copy link
Collaborator

@ngupta23 ngupta23 commented Feb 15, 2022

Related Issuse or bug

#2149

Describe the changes you've made

  • scatter changed to scattergl for faster rendering
  • Used fig.batch_update() to update figure in one shot
  • Switched from interactive renderer to static render above a certain number of data points but provided an option to users to specify renderer so they can still use interactive renderer if they wish.
  • Added example notebooks for exogenous variables and how to model with them (initial attempt)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Plotting unit tests ran locally and passed.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@ngupta23 ngupta23 added the time_series Topics related to the time series label Feb 15, 2022
@ngupta23 ngupta23 added this to In progress in Time Series Forecasting via automation Feb 15, 2022
@ngupta23 ngupta23 added this to the Time Series 202202 Release milestone Feb 15, 2022
Copy link
Member

@Yard1 Yard1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome!

@ngupta23 ngupta23 merged commit c18c196 into time_series Feb 15, 2022
Time Series Forecasting automation moved this from In progress to Done Feb 15, 2022
@ngupta23 ngupta23 deleted the ts_faster_plots branch February 15, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exogenous plot_model time_series Topics related to the time series
Development

Successfully merging this pull request may close these issues.

None yet

2 participants