Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for PACF & Global Imports #2227

Merged
merged 3 commits into from Mar 1, 2022
Merged

Fix for PACF & Global Imports #2227

merged 3 commits into from Mar 1, 2022

Conversation

ngupta23
Copy link
Collaborator

@ngupta23 ngupta23 commented Mar 1, 2022

Related Issuse or bug

Closes #2225
Closes #2226

Describe the changes you've made

  • Fix for global imports using from pycaret.time_series import *
  • Fix for PACF for short datasets

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Local testing done

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@ngupta23 ngupta23 added plot_model setup time_series Topics related to the time series labels Mar 1, 2022
@ngupta23 ngupta23 added this to In progress in Time Series Forecasting via automation Mar 1, 2022
@ngupta23 ngupta23 added this to the Time Series 202202 Release milestone Mar 1, 2022
@ngupta23 ngupta23 merged commit cda5ad0 into time_series Mar 1, 2022
Time Series Forecasting automation moved this from In progress to Done Mar 1, 2022
@ngupta23 ngupta23 deleted the ts_fix_feb28 branch March 1, 2022 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plot_model setup time_series Topics related to the time series
1 participant