Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored Time Series Forecasting #2251

Merged
merged 3 commits into from Mar 6, 2022
Merged

Refactored Time Series Forecasting #2251

merged 3 commits into from Mar 6, 2022

Conversation

ngupta23
Copy link
Collaborator

@ngupta23 ngupta23 commented Mar 6, 2022 •
edited

Related Issue or bug

Implements #1748 (for time series)
Closes #1914

Describe the changes you've made

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Partial unit tests run locally. Should pass on GitHub.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@ngupta23 ngupta23 added time_series Topics related to the time series refactor labels Mar 6, 2022
@ngupta23 ngupta23 added this to the Time Series 202203 Release milestone Mar 6, 2022
@ngupta23 ngupta23 added this to In progress in Time Series Forecasting via automation Mar 6, 2022
This was linked to issues Mar 6, 2022
Change name for INPI metric #1914
Closed
TimeSeriesExperiment refactor #1748
Closed
@ngupta23 ngupta23 merged commit 695b34f into time_series Mar 6, 2022
Time Series Forecasting automation moved this from In progress to Done Mar 6, 2022
@ngupta23 ngupta23 deleted the ts_cleanup branch March 6, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
refactor time_series Topics related to the time series
Projects
Time Series Forecasting
Done
Milestone
Time Series 202203 Release
Development

Successfully merging this pull request may close these issues.

Change name for INPI metric TimeSeriesExperiment refactor
1 participant
@ngupta23