Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time Series Plotting Enhancements #2262

Merged
merged 8 commits into from Mar 11, 2022
Merged

Time Series Plotting Enhancements #2262

merged 8 commits into from Mar 11, 2022

Conversation

ngupta23
Copy link
Collaborator

@ngupta23 ngupta23 commented Mar 10, 2022

Related Issuse or bug

Closes #2243
Closes #2244
Closes #2258
Closes #2103

Describe the changes you've made

Enhancements as described in the Issues listed above.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Some unit tests were verified locally, all to run on GitHub.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@ngupta23 ngupta23 marked this pull request as ready for review March 10, 2022 12:31
@ngupta23 ngupta23 added plot_model time_series Topics related to the time series labels Mar 10, 2022
@ngupta23 ngupta23 added this to In progress in Time Series Forecasting via automation Mar 10, 2022
@ngupta23 ngupta23 added this to the Time Series 202203 Release milestone Mar 10, 2022
@ngupta23 ngupta23 requested a review from Yard1 March 10, 2022 12:51
Copy link
Member

@Yard1 Yard1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question

pycaret/internal/plots/time_series.py Outdated Show resolved Hide resolved
@ngupta23 ngupta23 linked an issue Mar 11, 2022 that may be closed by this pull request
@ngupta23 ngupta23 merged commit 1ad4dc1 into time_series Mar 11, 2022
Time Series Forecasting automation moved this from In progress to Done Mar 11, 2022
@ngupta23 ngupta23 deleted the ts_enhance_plots branch March 11, 2022 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment