Added warning for not running setup before other functions

[ryanxjhan]

Related Issuse or bug

Info about Issue or bug

Fixes #2338

Describe the changes you've made

Added warning for not running setup before other functions.

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Code style update (formatting, local variables)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Pytest

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

NA

Checklist:

• My code follows the style guidelines of this project.
• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.
• I have made corresponding changes to the documentation.
• My changes generate no new warnings.
• I have added tests that prove my fix is effective or that my feature works.
• New and existing unit tests pass locally with my changes.
• Any dependent changes have been merged and published in downstream modules.

Screenshots

Original	Updated
original screenshot	updated screenshot

[ngupta23]

@Yard1 @ryanxjhan
I also feel that since the message is the same in all methods, it should be stored as a class attribute. That way, we only type it out once and reuse it in all methods. It will make maintenance easier later if we want to reword this.

[ryanxjhan]

@ngupta23 Agreed. What about implementing it as a private method?

[ngupta23]

@ngupta23 Agreed. What about implementing it as a private method?

I don't have an issue with that. @Yard1 Do you see any issues?

[Yard1]

The best practice here would be to use a decorator instead of editing all the methods

[ryanxjhan]

Hi @ngupta23, I have implemented the changes. Adding warnings in predict_model, load_model, and save_model does not pass some edge cases in pytest. So I removed the warnings from these methods.

[ngupta23]

Hi @ngupta23, I have implemented the changes. Adding warnings in predict_model, load_model, and save_model does not pass some edge cases in pytest. So I removed the warnings from these methods.

Yes that is correct - these methods do not need the setup to be run.

[ngupta23]

Changes look good. Falling test is unrelated to time series.
Also movement of this check to base class has been added as a separate issue for now.