Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time Series plotting enhancement #2405

Merged
merged 3 commits into from Apr 13, 2022
Merged

Time Series plotting enhancement #2405

merged 3 commits into from Apr 13, 2022

Conversation

ngupta23
Copy link
Collaborator

Related Issue or bug

Closes #2308

Describe the changes you've made

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Unit tests pass on GitHub

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@ngupta23 ngupta23 added time_series Topics related to the time series plot_model labels Apr 13, 2022
@ngupta23 ngupta23 added this to the pycaret 3.0.0 milestone Apr 13, 2022
@ngupta23 ngupta23 requested a review from Yard1 April 13, 2022 14:14
@ngupta23 ngupta23 added this to In progress in Time Series Forecasting via automation Apr 13, 2022
@ngupta23 ngupta23 linked an issue Apr 13, 2022 that may be closed by this pull request
2 tasks
Copy link
Member

@Yard1 Yard1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ngupta23 ngupta23 merged commit a5b10e3 into time_series Apr 13, 2022
Time Series Forecasting automation moved this from In progress to Done Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plot_model time_series Topics related to the time series
Development

Successfully merging this pull request may close these issues.

Refactor plot_model for time series
2 participants