Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure docstring consistency, remove silent arg #2611

Merged
merged 23 commits into from Jun 2, 2022
Merged

Conversation

Yard1
Copy link
Member

@Yard1 Yard1 commented May 31, 2022

Related Issue or bug

Info about Issue or bug

Closes #2499

Describe the changes you've made

A clear and concise description of what you have done to successfully close your assigned issue. Any new files? or anything you feel to let us know!

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots

Original Updated
original screenshot updated screenshot

@Yard1 Yard1 added this to the pycaret 3.0.0rc1 milestone May 31, 2022
@Yard1 Yard1 changed the title Ensure docstring consistency Ensure docstring consistency, remove silent arg May 31, 2022
@Yard1 Yard1 marked this pull request as ready for review June 1, 2022 20:06
Copy link
Collaborator

@tvdboom tvdboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for doing the boring job;)

@Yard1 Yard1 merged commit 8b1cec2 into develop Jun 2, 2022
@Yard1 Yard1 deleted the dynamic_function_api branch June 2, 2022 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants