Fix type hints #2663
Fix type hints #2663
Conversation
|
The tests failed. I think there is a problem with this pre-PR commit. Does anyone know the details? |
Can you pull in the latest develop branch into your branch and check. This may have fixed it for now. |
README.md
Outdated
| @@ -92,24 +98,6 @@ pip install pycaret[full] | |||
|
|
|||
| <div align="left"> | |||
|
|
|||
| ## ⚡ PyCaret Time Series Module (beta) | |||
There was a problem hiding this comment.
Maybe instead of removing this completely, we should reword this and say that it is integrated with the main pycaret. We have a lot of posts that point to this section of the readme for Time series
|
Do we need datasets/electricity.csv? If this is a new dataset, we should also add it to https://github.com/pycaret/datasets instead. |
There was a problem hiding this comment.
Most of this looks OK. I left a couple of minor comments that are unrelated to the actual PR about type hints. If you want, you can fix it here or leave them as is and submit a separate PR for those items to keep it clean (I will leave that decision up to you).
Thanks!
|
Thanks for the comment. And my apologies. There are unintended changes present, partly because the branch was created from the master. I will try to see if I can remove this (revert?). |
|
I have limited the PR diff to what was intended. I would appreciate your confirmation that this is correct. |
Related Issue or bug
Added and fixed about type hints. There is no associated Issue, but it enhances the readability and robustness of the code.
Type of change
How Has This Been Tested?
No changes were made that would change the behavior. If the CI test passes, you can be sure that there is no problem.