Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Time Series Plotting for some cases #3213

Merged
merged 5 commits into from Dec 30, 2022
Merged

Fixed Time Series Plotting for some cases #3213

merged 5 commits into from Dec 30, 2022

Conversation

ngupta23
Copy link
Collaborator

@ngupta23 ngupta23 commented Dec 29, 2022

Related Issue or bug

Closes #3212

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Testes locally and existing unit tests must pass on GH

import pandas as pd

data = pd.read_csv("Incident_data.csv")
data["date"] = pd.to_datetime(data["date"])
data.set_index("date", drop=True, inplace=True)
data = data.asfreq("d")

##Importing and Initializing time series module
from pycaret.time_series import *

forecast_tickets = setup(data, fold=5, fh=15, numeric_imputation_target="ffill")
plot_model(data_kwargs={"plot_data_type": ["original", "imputed"]})

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@ngupta23 ngupta23 added time_series Topics related to the time series plot_model labels Dec 29, 2022
@ngupta23 ngupta23 added this to In progress in Time Series Forecasting via automation Dec 29, 2022
@ngupta23 ngupta23 added this to the pycaret 3.0.0 milestone Dec 29, 2022
@ngupta23 ngupta23 merged commit be031be into master Dec 30, 2022
Time Series Forecasting automation moved this from In progress to Done Dec 30, 2022
@ngupta23 ngupta23 deleted the fix_ts_plotting branch December 30, 2022 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plot_model time_series Topics related to the time series
Development

Successfully merging this pull request may close these issues.

[BUG]: Time series plotting for some imputed datesets is not correct
2 participants