Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix data attributes and add random_state to remove outliers #3382

Merged
merged 4 commits into from Mar 13, 2023
Merged

fix data attributes and add random_state to remove outliers #3382

merged 4 commits into from Mar 13, 2023

Conversation

tvdboom
Copy link
Collaborator

@tvdboom tvdboom commented Mar 10, 2023 •
edited

Closes #3365

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@tvdboom tvdboom requested a review from Yard1 March 10, 2023 12:21
@Yard1
Merge branch 'master' into fix_data_attributes_calling
ca4b00c
@Yard1
Fix
53b9317 
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
@Yard1
Make our preprocessors follow sklearn API
3d524e4 
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
@Yard1 Yard1 merged commit dae5037 into master Mar 13, 2023
14 checks passed
@Yard1 Yard1 deleted the fix_data_attributes_calling branch March 13, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yard1 Yard1 Yard1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: remove_outliers behaving weird
2 participants
@tvdboom @Yard1