Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hashing of custom classes #3393

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Fix hashing of custom classes #3393

merged 1 commit into from
Mar 13, 2023

Conversation

Yard1
Copy link
Member

@Yard1 Yard1 commented Mar 12, 2023

Related Issue or bug

Info about Issue or bug

Closes #3384

Describe the changes you've made

Fixes joblib bug to allow classes defined in __main__ to be hashed.

Note that this issue will still happen if the class is defined inside a function. We'll need to use cloudpickle for that (left as TODO).

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots

Original Updated
original screenshot updated screenshot

Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
@Yard1 Yard1 merged commit c91e274 into master Mar 13, 2023
@Yard1 Yard1 deleted the fix_custom_class_hashing branch March 13, 2023 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: custom model failing
1 participant